== Series Details == Series: drm/i915/perf: Refactor oa object to better manage resources (rev6) URL : https://patchwork.freedesktop.org/series/60176/ State : warning == Summary == $ dim checkpatch origin/drm-tip ae33771060e0 drm/i915/perf: Refactor oa object to better manage resources -:523: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stream->oa_buffer.last_ctx_id == stream->specific_ctx_id' #523: FILE: drivers/gpu/drm/i915/i915_perf.c:791: + if (!dev_priv->perf.exclusive_stream->ctx || + stream->specific_ctx_id == ctx_id || + (stream->oa_buffer.last_ctx_id == + stream->specific_ctx_id) || reason & OAREPORT_REASON_CTX_SWITCH) { -:876: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #876: FILE: drivers/gpu/drm/i915/i915_perf.c:1366: + BUG_ON(stream != dev_priv->perf.exclusive_stream); -:1387: ERROR:CODE_INDENT: code indent should use tabs where possible #1387: FILE: drivers/gpu/drm/i915/i915_perf.c:2438: +^I^I poll_check_timer);$ -:1556: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #1556: FILE: drivers/gpu/drm/i915/i915_perf.c:3613: + dev_priv->perf.gen8_valid_ctx_bit = (1<<25); ^ -:1564: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #1564: FILE: drivers/gpu/drm/i915/i915_perf.c:3618: + dev_priv->perf.gen8_valid_ctx_bit = (1<<16); ^ -:1594: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #1594: FILE: drivers/gpu/drm/i915/i915_perf.c:3638: + dev_priv->perf.gen8_valid_ctx_bit = (1<<16); ^ -:1615: ERROR:CODE_INDENT: code indent should use tabs where possible #1615: FILE: drivers/gpu/drm/i915/i915_perf.c:3653: + ^I^I/* We set up some ratelimit state to potentially throttle any$ -:1615: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1615: FILE: drivers/gpu/drm/i915/i915_perf.c:3653: + ^I^I/* We set up some ratelimit state to potentially throttle any$ -:1615: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1615: FILE: drivers/gpu/drm/i915/i915_perf.c:3653: + ^I^I/* We set up some ratelimit state to potentially throttle any$ -:1616: ERROR:CODE_INDENT: code indent should use tabs where possible #1616: FILE: drivers/gpu/drm/i915/i915_perf.c:3654: + ^I^I * _NOTES about spurious, invalid OA reports which we don't$ -:1616: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1616: FILE: drivers/gpu/drm/i915/i915_perf.c:3654: + ^I^I * _NOTES about spurious, invalid OA reports which we don't$ -:1617: ERROR:CODE_INDENT: code indent should use tabs where possible #1617: FILE: drivers/gpu/drm/i915/i915_perf.c:3655: + ^I^I * forward to userspace.$ -:1617: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1617: FILE: drivers/gpu/drm/i915/i915_perf.c:3655: + ^I^I * forward to userspace.$ -:1618: ERROR:CODE_INDENT: code indent should use tabs where possible #1618: FILE: drivers/gpu/drm/i915/i915_perf.c:3656: + ^I^I *$ -:1618: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1618: FILE: drivers/gpu/drm/i915/i915_perf.c:3656: + ^I^I *$ -:1619: ERROR:CODE_INDENT: code indent should use tabs where possible #1619: FILE: drivers/gpu/drm/i915/i915_perf.c:3657: + ^I^I * We print a _NOTE about any throttling when closing the$ -:1619: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1619: FILE: drivers/gpu/drm/i915/i915_perf.c:3657: + ^I^I * We print a _NOTE about any throttling when closing the$ -:1620: ERROR:CODE_INDENT: code indent should use tabs where possible #1620: FILE: drivers/gpu/drm/i915/i915_perf.c:3658: + ^I^I * stream instead of waiting until driver _fini which no one$ -:1620: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1620: FILE: drivers/gpu/drm/i915/i915_perf.c:3658: + ^I^I * stream instead of waiting until driver _fini which no one$ -:1621: ERROR:CODE_INDENT: code indent should use tabs where possible #1621: FILE: drivers/gpu/drm/i915/i915_perf.c:3659: + ^I^I * would ever see.$ -:1621: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1621: FILE: drivers/gpu/drm/i915/i915_perf.c:3659: + ^I^I * would ever see.$ -:1622: ERROR:CODE_INDENT: code indent should use tabs where possible #1622: FILE: drivers/gpu/drm/i915/i915_perf.c:3660: + ^I^I *$ -:1622: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1622: FILE: drivers/gpu/drm/i915/i915_perf.c:3660: + ^I^I *$ -:1623: ERROR:CODE_INDENT: code indent should use tabs where possible #1623: FILE: drivers/gpu/drm/i915/i915_perf.c:3661: + ^I^I * Using the same limiting factors as printk_ratelimit()$ -:1623: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1623: FILE: drivers/gpu/drm/i915/i915_perf.c:3661: + ^I^I * Using the same limiting factors as printk_ratelimit()$ -:1624: ERROR:CODE_INDENT: code indent should use tabs where possible #1624: FILE: drivers/gpu/drm/i915/i915_perf.c:3662: + ^I^I */$ -:1624: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1624: FILE: drivers/gpu/drm/i915/i915_perf.c:3662: + ^I^I */$ -:1625: ERROR:CODE_INDENT: code indent should use tabs where possible #1625: FILE: drivers/gpu/drm/i915/i915_perf.c:3663: + ^I^Iratelimit_state_init(&dev_priv->perf.spurious_report_rs,$ -:1625: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1625: FILE: drivers/gpu/drm/i915/i915_perf.c:3663: + ^I^Iratelimit_state_init(&dev_priv->perf.spurious_report_rs,$ -:1625: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1625: FILE: drivers/gpu/drm/i915/i915_perf.c:3663: + ^I^Iratelimit_state_init(&dev_priv->perf.spurious_report_rs,$ -:1626: ERROR:CODE_INDENT: code indent should use tabs where possible #1626: FILE: drivers/gpu/drm/i915/i915_perf.c:3664: + ^I^I^I^I 5 * HZ, 10);$ -:1626: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1626: FILE: drivers/gpu/drm/i915/i915_perf.c:3664: + ^I^I^I^I 5 * HZ, 10);$ -:1626: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1626: FILE: drivers/gpu/drm/i915/i915_perf.c:3664: + ratelimit_state_init(&dev_priv->perf.spurious_report_rs, + 5 * HZ, 10); -:1626: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1626: FILE: drivers/gpu/drm/i915/i915_perf.c:3664: + ^I^I^I^I 5 * HZ, 10);$ -:1627: ERROR:CODE_INDENT: code indent should use tabs where possible #1627: FILE: drivers/gpu/drm/i915/i915_perf.c:3665: + ^I^I/* Since we use a DRM_NOTE for spurious reports it would be$ -:1627: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1627: FILE: drivers/gpu/drm/i915/i915_perf.c:3665: + ^I^I/* Since we use a DRM_NOTE for spurious reports it would be$ -:1627: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1627: FILE: drivers/gpu/drm/i915/i915_perf.c:3665: + ^I^I/* Since we use a DRM_NOTE for spurious reports it would be$ -:1628: ERROR:CODE_INDENT: code indent should use tabs where possible #1628: FILE: drivers/gpu/drm/i915/i915_perf.c:3666: + ^I^I * inconsistent to let __ratelimit() automatically print a$ -:1628: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1628: FILE: drivers/gpu/drm/i915/i915_perf.c:3666: + ^I^I * inconsistent to let __ratelimit() automatically print a$ -:1629: ERROR:CODE_INDENT: code indent should use tabs where possible #1629: FILE: drivers/gpu/drm/i915/i915_perf.c:3667: + ^I^I * warning for throttling.$ -:1629: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1629: FILE: drivers/gpu/drm/i915/i915_perf.c:3667: + ^I^I * warning for throttling.$ -:1630: ERROR:CODE_INDENT: code indent should use tabs where possible #1630: FILE: drivers/gpu/drm/i915/i915_perf.c:3668: + ^I^I */$ -:1630: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1630: FILE: drivers/gpu/drm/i915/i915_perf.c:3668: + ^I^I */$ -:1631: ERROR:CODE_INDENT: code indent should use tabs where possible #1631: FILE: drivers/gpu/drm/i915/i915_perf.c:3669: + ^I^Iratelimit_set_flags(&dev_priv->perf.spurious_report_rs,$ -:1631: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1631: FILE: drivers/gpu/drm/i915/i915_perf.c:3669: + ^I^Iratelimit_set_flags(&dev_priv->perf.spurious_report_rs,$ -:1631: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1631: FILE: drivers/gpu/drm/i915/i915_perf.c:3669: + ^I^Iratelimit_set_flags(&dev_priv->perf.spurious_report_rs,$ -:1632: ERROR:CODE_INDENT: code indent should use tabs where possible #1632: FILE: drivers/gpu/drm/i915/i915_perf.c:3670: + ^I^I^I^I RATELIMIT_MSG_ON_RELEASE);$ -:1632: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1632: FILE: drivers/gpu/drm/i915/i915_perf.c:3670: + ^I^I^I^I RATELIMIT_MSG_ON_RELEASE);$ -:1632: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1632: FILE: drivers/gpu/drm/i915/i915_perf.c:3670: + ratelimit_set_flags(&dev_priv->perf.spurious_report_rs, + RATELIMIT_MSG_ON_RELEASE); -:1632: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1632: FILE: drivers/gpu/drm/i915/i915_perf.c:3670: + ^I^I^I^I RATELIMIT_MSG_ON_RELEASE);$ total: 19 errors, 25 warnings, 6 checks, 2092 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
