Quoting Michal Wajdeczko (2019-08-07 18:00:31) > For meaningful WOPCM partitioning we need GuC (and optionally HuC) > firmware size(s) and we shouldn't just rely on GuC support flag, > as we might fail to fetch GuC firmware and it's size will be 0 > and all calculations will be just wrong/useless. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_wopcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c > index 4c22143ee84f..5e5c3fd3472d 100644 > --- a/drivers/gpu/drm/i915/intel_wopcm.c > +++ b/drivers/gpu/drm/i915/intel_wopcm.c > @@ -170,7 +170,7 @@ void intel_wopcm_init(struct intel_wopcm *wopcm) > u32 guc_wopcm_rsvd; > int err; > > - if (!USES_GUC(i915)) > + if (!guc_fw_size) > return; It looks like the calculations with huc_fw_size=0 are fine, just hope the fw agrees. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
