Hi Chris, On Tue, Jul 30, 2019 at 02:30:31PM +0100, Chris Wilson wrote: > This giant switch has tendrils all other the struct and does not fit > into the rest of the driver bring up and control of i915_drv.c. Push it > to one side so that it can grow in peace. > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> [...] > - struct drm_i915_private *dev_priv = to_i915(dev); > - struct pci_dev *pdev = dev_priv->drm.pdev; > - const struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu; > - drm_i915_getparam_t *param = data; > - int value; [...] > + struct drm_i915_private *i915 = to_i915(dev); > + const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu; > + drm_i915_getparam_t *param = data; > + int value; I knew you could not resist the temptation of changing things on the fly :) Would be nice to have _any_ change documented in the log. In any case: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx> Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
