== Series Details == Series: drm/ttm: make ttm bo a gem bo subclass (rev2) URL : https://patchwork.freedesktop.org/series/64701/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7942960fb839 drm/ttm: add gem base object -:66: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "bo->base.dev" #66: FILE: include/drm/ttm/ttm_bo_api.h:792: + return bo->base.dev != NULL; total: 0 errors, 0 warnings, 1 checks, 45 lines checked c5cd0b845747 drm/vram: use embedded gem object 4e6111013097 drm/qxl: use embedded gem object -:117: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #117: FILE: drivers/gpu/drm/qxl/qxl_drv.h:96: }; +#define gem_to_qxl_bo(gobj) container_of((gobj), struct qxl_bo, tbo.base) total: 0 errors, 0 warnings, 1 checks, 200 lines checked f81600d76439 drm/radeon: use embedded gem object -:34: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #34: FILE: drivers/gpu/drm/radeon/radeon.h:515: }; +#define gem_to_radeon_bo(gobj) container_of((gobj), struct radeon_bo, tbo.base) total: 0 errors, 0 warnings, 1 checks, 107 lines checked bea743601c7f drm/amdgpu: use embedded gem object de81159a89a1 drm/nouveau: use embedded gem object 752718b89ddf drm/ttm: use gem reservation object -:38: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #38: FILE: drivers/gpu/drm/ttm/ttm_bo.c:445: + BUG_ON(!reservation_object_trylock(&bo->base._resv)); total: 0 errors, 1 warnings, 0 checks, 109 lines checked 2cb5b47de497 drm/ttm: use gem vma_node a675831623e1 drm/ttm: set both resv and base.resv pointers 87e8a39960ee drm/ttm: switch ttm core from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 521 lines checked 4340629abc3d drm/radeon: switch driver from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:101: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #101: FILE: drivers/gpu/drm/radeon/radeon_mn.c:167: + r = reservation_object_wait_timeout_rcu(bo->tbo.base.resv, true, false, MAX_SCHEDULE_TIMEOUT); total: 0 errors, 1 warnings, 1 checks, 163 lines checked 16bc96755985 drm/vmwgfx: switch driver from bo->resv to bo->base.resv -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 79 lines checked 84947a534700 drm/amdgpu: switch driver from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:163: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #163: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: + r = reservation_object_wait_timeout_rcu(bo->tbo.base.resv, true, false, MAX_SCHEDULE_TIMEOUT); total: 0 errors, 1 warnings, 1 checks, 380 lines checked f08db36ee75f drm/nouveau: switch driver from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 47 lines checked 626203105d17 drm/qxl: switch driver from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 27 lines checked 4c830922c534 drm/virtio: switch driver from bo->resv to bo->base.resv -:10: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 24 lines checked 36fbdc73524a drm/ttm: drop ttm_buffer_object->resv _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx