Re: [PATCH] drm/i915/dmc: Load DMC on TGL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2019-08-02 at 11:38 -0700, Lucas De Marchi wrote:
> From: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> 
> Add Support to load DMC v2.03 on TGL.
> 
> v2: Use version 2.03 that is already available since that works with
>     PSR2

Still not available on 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915

But the patch looks good

Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>

> 
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> Reviewed-by: Matt Atwood <matthew.s.atwood@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c
> b/drivers/gpu/drm/i915/intel_csr.c
> index 6ef74531588a..8279e72edf4c 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -39,6 +39,11 @@
>  
>  #define GEN12_CSR_MAX_FW_SIZE		ICL_CSR_MAX_FW_SIZE
>  
> +#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_03.bin"
> +#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 3)
> +#define TGL_CSR_MAX_FW_SIZE		0x6000
> +MODULE_FIRMWARE(TGL_CSR_PATH);
> +
>  #define ICL_CSR_PATH			"i915/icl_dmc_ver1_07.bin"
>  #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>  #define ICL_CSR_MAX_FW_SIZE		0x6000
> @@ -674,6 +679,8 @@ void intel_csr_ucode_init(struct drm_i915_private
> *dev_priv)
>  	intel_csr_runtime_pm_get(dev_priv);
>  
>  	if (INTEL_GEN(dev_priv) >= 12) {
> +		csr->fw_path = TGL_CSR_PATH;
> +		csr->required_version = TGL_CSR_VERSION_REQUIRED;
>  		/* Allow to load fw via parameter using the last known
> size */
>  		csr->max_fw_size = GEN12_CSR_MAX_FW_SIZE;
>  	} else if (IS_GEN(dev_priv, 11)) {
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux