Quoting Vinay Belgaumkar (2019-07-31 19:31:38)
>
>
> On 07/29/2019 12:19 PM, Chris Wilson wrote:
> > Check for viability of store-dword before use.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > ---
> > tests/i915/gem_exec_schedule.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> > index 4ccacba41..6e8466299 100644
> > --- a/tests/i915/gem_exec_schedule.c
> > +++ b/tests/i915/gem_exec_schedule.c
> > @@ -282,9 +282,11 @@ static void smoketest(int fd, unsigned ring, unsigned timeout)
> > nengine = 0;
> > if (ring == ALL_ENGINES) {
> > for_each_physical_engine(fd, engine)
> > - engines[nengine++] = engine;
> > + if (gem_can_store_dword(fd, engine))
> > + engines[nengine++] = engine;
> > } else {
>
> The gem_can_store_dword() check is already executed in the fixture for
> per engine smoketest, right?
> We only need it for the smoketest-all case?
Yes, but I liked the symmetry.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
