On Tue, 30 Jul 2019 21:07:28 +0200, Chris Wilson
<chris@xxxxxxxxxxxxxxxxxx> wrote:
+static const char* __override_huc_firmware_path(void)
+{
+ if ((i915_modparams.enable_guc < 0) ||
+ (i915_modparams.enable_guc & ENABLE_GUC_LOAD_HUC))
+ return i915_modparams.huc_firmware_path;
We can even lose the <0. No negative value other than -1 is documented.
I used <0 to match existing implementation in sanitize_options_early()
/* A negative value means "use platform default" */
if (i915_modparams.enable_guc < 0)
i915_modparams.enable_guc = __get_platform_enable_guc(uc);
if we lose <0 condition there are questions how to treat undocumented
values:
-2 is disabled(0) or auto but without submission aka huc-only(2)
-3 is disabled(0) or auto but without huc aka submission_only(1)
...
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
