== Series Details == Series: Don't sanitize enable_guc URL : https://patchwork.freedesktop.org/series/64446/ State : warning == Summary == $ dim checkpatch origin/drm-tip 26060db5e380 drm/i915/uc: Consider enable_guc modparam during fw selection -:81: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i915_modparams.enable_guc < 0' #81: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:137: + if ((i915_modparams.enable_guc < 0) && (p < INTEL_ICELAKE)) -:81: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p < INTEL_ICELAKE' #81: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:137: + if ((i915_modparams.enable_guc < 0) && (p < INTEL_ICELAKE)) -:85: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #85: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:141: +static const char* __override_guc_firmware_path(void) -:88: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i915_modparams.enable_guc < 0' #88: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:144: + if ((i915_modparams.enable_guc < 0) || + (i915_modparams.enable_guc & ENABLE_GUC_LOAD_HUC)) -:94: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #94: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:150: +static const char* __override_huc_firmware_path(void) -:96: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i915_modparams.enable_guc < 0' #96: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:152: + if ((i915_modparams.enable_guc < 0) || + (i915_modparams.enable_guc & ENABLE_GUC_LOAD_HUC)) total: 2 errors, 0 warnings, 4 checks, 79 lines checked b73f7436e919 drm/i915/guc: Use dedicated flag to track submission mode 8b60c2d8e654 drm/i915/uc: Stop sanitizing enable_guc modparam _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
