Re: [PATCH 6/6] drm/i915/gt: introduce intel_gt_suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/30/19 1:12 AM, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-07-30 08:33:28)

On 30/07/2019 00:47, Daniele Ceraolo Spurio wrote:
For symmetry with intel_gt_resume and to hide more stuff from the top
level under intel_gt. Note that the switch_to_kernel_context_sync has
not been moved dure to the locking and ordering requirements that exist

Typo in due.

Should we add intel_gt_suspend_early/late, with the former dealing with
switch_to_kernel_context_sync? Although that raises an interesting
conundrum since it operates on GEM and GT. Best then to leave it
unwrapped for now I think.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Ah, I wouldn't apply this patch yet for exactly that reason: we
shouldn't be driving GT suspend from inside GEM, so would wait until we
have a few more pieces of the puzzle reviewed^W unravelled.
-Chris


Ok, I'll drop the last 2 patches in the series for now.

Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux