Re: [RFC PATCH 1/3] drm: introduce new struct drm_mem_region

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Brian.

Small nit below - did not try to understand your patch.

	Sam

> diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
> index 2c3bbb43c7d1..3d123eb10d62 100644
> --- a/include/drm/drm_mm.h
> +++ b/include/drm/drm_mm.h
> @@ -43,6 +43,8 @@
>  #include <linux/mm_types.h>
>  #include <linux/list.h>
>  #include <linux/spinlock.h>
> +#include <linux/dma-fence.h>
> +#include <linux/io-mapping.h>

Keep include files sorted.

>  #ifdef CONFIG_DRM_DEBUG_MM
>  #include <linux/stackdepot.h>
>  #endif
> @@ -54,6 +56,31 @@
>  #define DRM_MM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr)
>  #endif
>  
> +struct drm_device;
> +struct drm_mm;
Likewise forwards. But they are good here.

	Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux