On 22/07/2019 17:28, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-07-22 13:33:14)
On 18/07/2019 08:00, Chris Wilson wrote:
@@ -1113,9 +1121,8 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
set_ppgtt_barrier,
old);
if (err) {
- ctx->vm = old;
- ctx->desc_template = default_desc_template(ctx->i915, old);
- i915_vm_put(vm);
+ i915_vm_put(__set_ppgtt(ctx, old));
+ i915_vm_put(old);
Shouldn't this still be i915_vm_out(vm), for the extra vm reference the
function did further up?
__set_ppgtt() returns the vm, so this is
i915_vm_put(vm);
i915_vm_put(old); /* since we just acquired a ref to old again */
get(old), put(vm), put(old) - okay, you seem to be right indeed.
Fix a typo in subject and:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
