Quoting Daniele Ceraolo Spurio (2019-07-23 00:20:47) > The gt is our new central structure for uc-related code, so we can use > that instead of jumping back to i915 via the fw object. Since we have it > in the upload function it is easy to pass it through the lower levels of > the xfer process instead of continuosly jumping via uc_fw->uc->gt, which > will also make things a bit cleaner for the next patch. > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > @@ -103,13 +101,13 @@ static void guc_prepare_xfer(struct intel_guc *guc) > } > > /* Copy RSA signature from the fw image to HW for verification */ > -static void guc_xfer_rsa(struct intel_guc *guc) > +static void guc_xfer_rsa(struct intel_uc_fw *guc_fw, intel_uc_fw *guc_fw is rubbing me the wrong way. I would have just used fw since that is unambiguous here. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
