✗ Fi.CI.CHECKPATCH: warning for uC fw path unification + misc clean-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: uC fw path unification + misc clean-up
URL   : https://patchwork.freedesktop.org/series/64039/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1defc4182153 drm/i915/uc: Gt-fy uc reset
ad3b67774d80 drm/i915/uc: Unify uC platform check
5917a7b6440c drm/i915/uc: Unify uC FW selection
-:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects?
#114: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c:41:
+#define GUC_FW_BLOB(prefix_, major_, minor_, patch_) \
+UC_FW_BLOB(prefix_##_guc, major_, minor_, \
+	   __MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_))

-:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects?
#114: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c:41:
+#define GUC_FW_BLOB(prefix_, major_, minor_, patch_) \
+UC_FW_BLOB(prefix_##_guc, major_, minor_, \
+	   __MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_))

-:238: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects?
#238: FILE: drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c:30:
+#define HUC_FW_BLOB(prefix_, major_, minor_, bld_num_) \
+UC_FW_BLOB(prefix_##_huc, major_, minor_, \
+	   HUC_FW_PATH(prefix_, major_, minor_, bld_num_))

-:238: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects?
#238: FILE: drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c:30:
+#define HUC_FW_BLOB(prefix_, major_, minor_, bld_num_) \
+UC_FW_BLOB(prefix_##_huc, major_, minor_, \
+	   HUC_FW_PATH(prefix_, major_, minor_, bld_num_))

-:350: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'path_' - possible side-effects?
#350: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h:58:
+#define UC_FW_BLOB(prefix_, major_, minor_, path_) \
+static const struct intel_uc_fw_blob prefix_##_fw_blob = { \
+	.major = (major_), \
+	.minor = (minor_), \
+	.path = path_ \
+}; \
+MODULE_FIRMWARE(path_)

total: 0 errors, 0 warnings, 5 checks, 338 lines checked
473061d8d2ff drm/i915/uc: Sanitize uC when GT is sanitized
8f847de27248 drm/i915/uc: Unify uc_fw status tracking
e2ad9c1b0a09 drm/i915/uc: Move xfer rsa logic to common function
23717b64a014 drm/i915/huc: Copy huc rsa only once
f539a9c8d4f1 drm/i915/uc: Plumb the gt through fw_upload
1a6f761311a2 drm/i915/uc: Unify uC firmware upload
-:291: WARNING:TYPO_SPELLING: 'trasfer' may be misspelled - perhaps 'transfer'?
#291: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:292:
+	 * Set the trasfer size. The header plus uCode will be copied to WOPCM

total: 0 errors, 1 warnings, 0 checks, 334 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux