On 7/13/2019 3:19 AM, Chris Wilson wrote:
Quoting Chris Wilson (2019-07-13 11:00:08)
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
Instead of always checking in the device config is GuC and HuC are
supported or not, we can save the state in the uc_fw structure and
avoid going through i915 every time from the low-level uc management
code. while at it FIRMWARE_NONE has been renamed to better indicate that
we haven't started the fetch/load yet, but we might have already selected
a blob.
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
Ok, but I'm not quite getting the feeling of a nice flow through a state
machine.
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
We had discussed a couple of possible different approaches with Michal
on the other thread, including a better state machine that unifies the
fetch/load cases, I just didn't have time to try them yet. Since the
series is fully reviewed, if you want to get it in while it still
applies I will follow up with that rework on top.
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
