Quoting Daniel Vetter (2019-07-12 13:51:58)
> On Fri, Jul 12, 2019 at 2:01 PM Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > A buffer is created in response to the user ioctl, it should therefore
> > be a plain DRM_DEBUG() message to reflect it being a user invoked
> > response and not a driver construct.
> >
> > This is just to make the commonplace drm.debug=[26e] quieter when
> > running with vgem.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > ---
> > drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> > index 386efc3b5843..76d95b5e289c 100644
> > --- a/drivers/gpu/drm/vgem/vgem_drv.c
> > +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> > @@ -214,7 +214,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
> > args->size = gem_object->size;
> > args->pitch = pitch;
> >
> > - DRM_DEBUG_DRIVER("Created object of size %lld\n", size);
> > + DRM_DEBUG("Created object of size %lld\n", size);
>
> Hm, I honestly dunno what DRM_DEBUG is for, except generating noise.
> Maybe also ditch this outright. Either approach gets my
Noise that sometimes may be useful in desperation. Is it more useful
than the ioctl reporting 0? A tiny bit more convincing/reassuring that
the driver is doing what you asked.
If we ever get a dynamic per-user/client debug log, this is certainly a
good candidate.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
