== Series Details == Series: drm/i915: Vulkan performance query support (rev9) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim checkpatch origin/drm-tip d2955d0798d1 drm/i915/perf: introduce a versioning of the i915-perf uapi 9c699978e47f drm/i915/perf: allow for CS OA configs to be created lazily -:139: CHECK:SPACING: No space is necessary after a cast #139: FILE: drivers/gpu/drm/i915/i915_perf.c:399: + (u32) MI_LOAD_REGISTER_IMM_MAX_REGS); total: 0 errors, 0 warnings, 1 checks, 361 lines checked 2bc449b28e4f drm/i915/perf: implement active wait for noa configurations -:39: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #39: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:237: +#define MI_MATH(x) MI_INSTR(0x1a, (x)-1) ^ -:118: CHECK:LINE_SPACING: Please don't use multiple blank lines #118: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3680: + + -:175: CHECK:LINE_SPACING: Please don't use multiple blank lines #175: FILE: drivers/gpu/drm/i915/i915_perf.c:450: + -:200: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #200: FILE: drivers/gpu/drm/i915/i915_perf.c:1667: + uint32_t d; -:225: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #225: FILE: drivers/gpu/drm/i915/i915_perf.c:1692: + DIV64_U64_ROUND_UP( -:250: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #250: FILE: drivers/gpu/drm/i915/i915_perf.c:1717: + batch = cs = i915_gem_object_pin_map(bo, I915_MAP_WB); -:258: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #258: FILE: drivers/gpu/drm/i915/i915_perf.c:1725: + cs = save_restore_register( -:262: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #262: FILE: drivers/gpu/drm/i915/i915_perf.c:1729: + cs = save_restore_register( -:362: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #362: FILE: drivers/gpu/drm/i915/i915_perf.c:1829: + cs = save_restore_register( -:366: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #366: FILE: drivers/gpu/drm/i915/i915_perf.c:1833: + cs = save_restore_register( total: 0 errors, 0 warnings, 10 checks, 384 lines checked 4d526c6d987d drm/i915: introduce a mechanism to extend execbuf2 -:129: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #129: FILE: include/uapi/drm/i915_drm.h:1171: +#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_EXT<<1)) ^ total: 0 errors, 0 warnings, 1 checks, 105 lines checked 138ca08070d2 drm/i915: add syncobj timeline support -:361: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'? #361: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2510: + * The chain's ownership is transfered to the -:392: ERROR:CODE_INDENT: code indent should use tabs where possible #392: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2541: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ -:392: WARNING:LEADING_SPACE: please, no spaces at the start of a line #392: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2541: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ total: 1 errors, 2 warnings, 0 checks, 530 lines checked efe63781a792 drm/i915: add a new perf configuration execbuf parameter -:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #27: v7: Hold drm.struct_mutex when serializing the request with OA config (Chris) -:52: CHECK:LINE_SPACING: Please don't use multiple blank lines #52: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1218: + -:146: ERROR:CODE_INDENT: code indent should use tabs where possible #146: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2618: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ -:146: WARNING:LEADING_SPACE: please, no spaces at the start of a line #146: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2618: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ total: 1 errors, 2 warnings, 1 checks, 415 lines checked ab69d6bbb2b5 drm/i915/perf: allow holding preemption on filtered ctx -:124: WARNING:BRACES: braces {} are not necessary for single statement blocks #124: FILE: drivers/gpu/drm/i915/i915_perf.c:2952: + if (IS_HASWELL(dev_priv) && specific_ctx && !props->hold_preemption) { privileged_op = false; + } total: 0 errors, 1 warnings, 0 checks, 123 lines checked 2bfb22c42eca drm/i915/perf: execute OA configuration from command stream 1e247fc19400 drm/i915: add support for perf configuration queries -:195: WARNING:BRACES: braces {} are not necessary for single statement blocks #195: FILE: drivers/gpu/drm/i915/i915_query.c:250: + if (__get_user(config_id, &user_query_config_ptr->config)) { + return -EFAULT; + } total: 0 errors, 1 warnings, 0 checks, 422 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx