✗ Fi.CI.CHECKPATCH: warning for Rename functions to match their entry points

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Rename functions to match their entry points
URL   : https://patchwork.freedesktop.org/series/63498/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
918d25b99c3e drm/i915: Rename "_load"/"_unload" to match PCI entry points
-:56: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#56: FILE: drivers/gpu/drm/i915/i915_drv.h:2398:
+extern int i915_driver_probe(struct pci_dev *pdev,

-:57: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#57: FILE: drivers/gpu/drm/i915/i915_drv.h:2399:
+extern int i915_driver_probe(struct pci_dev *pdev,
 			    const struct pci_device_id *ent);

-:59: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#59: FILE: drivers/gpu/drm/i915/i915_drv.h:2400:
+extern void i915_driver_remove(struct drm_device *dev);

total: 0 errors, 0 warnings, 3 checks, 55 lines checked
0d07a035491e drm/i915: Replace "_load" with "_probe" consequently
a01c5039702d drm/i915: Propagate "_release" function name suffix down
c899c5e11c03 drm/i915: Propagate "_remove" function name suffix down
-:194: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#194: FILE: drivers/gpu/drm/i915/i915_drv.h:2695:
+extern void intel_modeset_driver_remove(struct drm_device *dev);

-:250: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#250: FILE: drivers/gpu/drm/i915/intel_gvt.h:41:
 }
+static inline void intel_gvt_driver_remove(struct drm_i915_private *dev_priv)

total: 0 errors, 0 warnings, 2 checks, 183 lines checked
ac7ebaf5f172 drm/i915: Propagate "_probe" function name suffix down
accec2284e64 drm/i915: Rename "inject_load_failure" module parameter
-:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#55: FILE: drivers/gpu/drm/i915/i915_params.c:169:
+i915_param_named_unsafe(inject_probe_failure, uint, 0400,
 	"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");

total: 0 errors, 0 warnings, 1 checks, 41 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux