== Series Details == Series: drm/i915: Vulkan performance query support (rev8) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim checkpatch origin/drm-tip 77863bf0383c drm/i915/perf: ensure we keep a reference on the driver 8f7a0808f250 drm/i915/perf: add missing delay for OA muxes configuration 080184f9a064 drm/i915/perf: introduce a versioning of the i915-perf uapi 1722df82866e drm/i915/perf: allow for CS OA configs to be created lazily -:139: CHECK:SPACING: No space is necessary after a cast #139: FILE: drivers/gpu/drm/i915/i915_perf.c:399: + (u32) MI_LOAD_REGISTER_IMM_MAX_REGS); total: 0 errors, 0 warnings, 1 checks, 361 lines checked e248db13eb2d drm/i915: enumerate scratch fields -:25: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #25: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:30: { + -:89: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #89: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1833: + batch = gen8_emit_pipe_control( total: 0 errors, 0 warnings, 2 checks, 171 lines checked 665a7ba96f68 drm/i915/perf: implement active wait for noa configurations -:37: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #37: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:230: +#define MI_MATH(x) MI_INSTR(0x1a, (x)-1) ^ -:116: CHECK:LINE_SPACING: Please don't use multiple blank lines #116: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3685: + + -:173: CHECK:LINE_SPACING: Please don't use multiple blank lines #173: FILE: drivers/gpu/drm/i915/i915_perf.c:450: + -:197: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #197: FILE: drivers/gpu/drm/i915/i915_perf.c:1666: + uint32_t d; -:213: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #213: FILE: drivers/gpu/drm/i915/i915_perf.c:1682: + uint32_t d; -:231: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #231: FILE: drivers/gpu/drm/i915/i915_perf.c:1700: + DIV64_U64_ROUND_UP( -:256: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #256: FILE: drivers/gpu/drm/i915/i915_perf.c:1725: + batch = cs = i915_gem_object_pin_map(bo, I915_MAP_WB); total: 0 errors, 0 warnings, 7 checks, 388 lines checked 424cd5c33da4 drm/i915: introduce a mechanism to extend execbuf2 -:129: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #129: FILE: include/uapi/drm/i915_drm.h:1171: +#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_EXT<<1)) ^ total: 0 errors, 0 warnings, 1 checks, 105 lines checked d3006d85875a drm/i915: add syncobj timeline support -:361: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'? #361: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2510: + * The chain's ownership is transfered to the -:392: ERROR:CODE_INDENT: code indent should use tabs where possible #392: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2541: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ -:392: WARNING:LEADING_SPACE: please, no spaces at the start of a line #392: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2541: + [DRM_I915_GEM_EXECBUFFER_EXT_TIMELINE_FENCES] = parse_timeline_fences,$ total: 1 errors, 2 warnings, 0 checks, 530 lines checked 2869d3ccb40c drm/i915: add a new perf configuration execbuf parameter -:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #27: v7: Hold drm.struct_mutex when serializing the request with OA config (Chris) -:52: CHECK:LINE_SPACING: Please don't use multiple blank lines #52: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1218: + -:151: ERROR:CODE_INDENT: code indent should use tabs where possible #151: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2623: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ -:151: WARNING:LEADING_SPACE: please, no spaces at the start of a line #151: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2623: + [DRM_I915_GEM_EXECBUFFER_EXT_PERF] = parse_perf_config,$ total: 1 errors, 2 warnings, 1 checks, 420 lines checked 16c9d7873e66 drm/i915: add infrastructure to hold off preemption on a request 9d36d4d2936e drm/i915/perf: allow holding preemption on filtered ctx -:124: WARNING:BRACES: braces {} are not necessary for single statement blocks #124: FILE: drivers/gpu/drm/i915/i915_perf.c:2972: + if (IS_HASWELL(dev_priv) && specific_ctx && !props->hold_preemption) { privileged_op = false; + } total: 0 errors, 1 warnings, 0 checks, 123 lines checked af566a9a1d5a drm/i915/perf: execute OA configuration from command stream d80ced697843 drm/i915: add support for perf configuration queries -:174: WARNING:BRACES: braces {} are not necessary for single statement blocks #174: FILE: drivers/gpu/drm/i915/i915_query.c:250: + if (__get_user(config_id, &user_query_config_ptr->config)) { + return -EFAULT; + } total: 0 errors, 1 warnings, 0 checks, 405 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
