Re: [PATCH v2 03/14] drm/sti: Remove pointless casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le lun. 8 juil. 2019 à 18:21, Ville Syrjala
<ville.syrjala@xxxxxxxxxxxxxxx> a écrit :
>
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> There's no point in the cast for accessing the base class. Just
> take the address of the struct instead.

Applied on drm-misc-next,
Thanks,

Benjamin

>
> Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> Cc: Vincent Abriou <vincent.abriou@xxxxxx>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/sti/sti_tvout.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index e1b3c8cb7287..42f4c264a783 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -669,7 +669,7 @@ sti_tvout_create_dvo_encoder(struct drm_device *dev,
>
>         encoder->tvout = tvout;
>
> -       drm_encoder = (struct drm_encoder *)encoder;
> +       drm_encoder = &encoder->encoder;
>
>         drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
>         drm_encoder->possible_clones = 1 << 0;
> @@ -722,7 +722,7 @@ static struct drm_encoder *sti_tvout_create_hda_encoder(struct drm_device *dev,
>
>         encoder->tvout = tvout;
>
> -       drm_encoder = (struct drm_encoder *) encoder;
> +       drm_encoder = &encoder->encoder;
>
>         drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
>         drm_encoder->possible_clones = 1 << 0;
> @@ -771,7 +771,7 @@ static struct drm_encoder *sti_tvout_create_hdmi_encoder(struct drm_device *dev,
>
>         encoder->tvout = tvout;
>
> -       drm_encoder = (struct drm_encoder *) encoder;
> +       drm_encoder = &encoder->encoder;
>
>         drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
>         drm_encoder->possible_clones = 1 << 1;
> --
> 2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux