Re: [PATCH 2/3] drm/i915/selftests: Be engine agnostic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 Jul 2019 at 21:05, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>
> When using MI operations, we do not care which engine we use, so use
> them all where possible, and where inconvenient double check we have the
> engine we selected at random.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

<snip>

>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index a23c6df9b9f4..ecb59f14ec01 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1027,7 +1027,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915,
>         struct drm_file *file;
>         int ret;
>
> -       if (INTEL_GEN(i915) < 9)
> +       if (INTEL_GEN(i915) < 9 || !engine)
>                 return 0;

We already dereferenced engine above.

Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux