Re: [PATCH 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-07-02 11:23:11)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> Some interrupt handling functions already have gt in their names
> suggesting them as obvious candidates to make them take struct intel_gt
> instead of i915.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Co-authored-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>

>  static void
> -gen11_other_irq_handler(struct drm_i915_private * const i915,
> -                       const u8 instance, const u16 iir)
> +gen11_other_irq_handler(struct intel_gt *gt, const u8 instance,
> +                       const u16 iir)
>  {
> +       struct drm_i915_private *i915 = gt->i915;
> +
>         if (instance == OTHER_GUC_INSTANCE)
>                 return gen11_guc_irq_handler(i915, iir);

That looks like a candidate for gt as well. Even for the guc, the
interrupt vector is GT centric. I was hoping we could place guc/ parallel
to gt/, but it looks like it will indeed be a child of intel_gt.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux