✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use intel_crtc_state everywhere!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: Use intel_crtc_state everywhere!
URL   : https://patchwork.freedesktop.org/series/62920/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
86e398aa0e65 drm/i915: Pass intel_crtc_state to needs_modeset()
83682e1854bb drm/i915: Convert most of atomic commit to take more intel state
-:449: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#449: FILE: drivers/gpu/drm/i915/display/intel_display.c:6675:
+	crtc->enabled_power_domains = new_domains =

-:770: WARNING:LONG_LINE: line over 100 characters
#770: FILE: drivers/gpu/drm/i915/display/intel_display.c:13647:
+		for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {

total: 0 errors, 1 warnings, 1 checks, 1060 lines checked
a6061facf2c3 drm/i915: Convert hw state verifier to take more intel state, v2.
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/display/intel_display.c:6999:
+		I915_STATE_WARN(!crtc_state->base.active,
 		      "connector is active, but attached crtc isn't\n");

-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_display.c:7011:
+		I915_STATE_WARN(crtc_state && crtc_state->base.active,
 			"attached crtc is active, but connector isn't\n");

-:210: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#210: FILE: drivers/gpu/drm/i915/display/intel_display.c:12939:
+	I915_STATE_WARN(new_crtc_state->base.active != active,
 	     "crtc active state doesn't match with hw state "

-:216: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#216: FILE: drivers/gpu/drm/i915/display/intel_display.c:12943:
+	I915_STATE_WARN(crtc->active != new_crtc_state->base.active,
 	     "transitional active state does not match atomic hw state "

-:227: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#227: FILE: drivers/gpu/drm/i915/display/intel_display.c:12951:
+		I915_STATE_WARN(active != new_crtc_state->base.active,
 			"[ENCODER:%i] active %i with crtc active %i\n",

-:308: WARNING:LONG_LINE: line over 100 characters
#308: FILE: drivers/gpu/drm/i915/display/intel_display.c:13053:
+		verify_single_dpll_state(dev_priv, new_crtc_state->shared_dpll, crtc, new_crtc_state);

total: 0 errors, 1 warnings, 5 checks, 346 lines checked
2fe9f8734334 drm/i915: Use intel_crtc_state in sanitize_watermarks() too
73e1ba270a31 drm/i915: Pass intel state to plane functions as well
-:180: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#180: FILE: drivers/gpu/drm/i915/display/intel_display.c:11358:
+		plane_state->base.visible = visible = false;

total: 0 errors, 0 warnings, 1 checks, 211 lines checked
8e4ffa6ce214 drm/i915: Use intel state as much as possible in wm code

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux