On Thu, 27 Jun 2019, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> Quoting Jani Nikula (2019-06-27 10:19:14)
>> The static keyword was apparently accidentally removed in commit
>> 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs"), leading to
>> sparse warning:
>>
>> drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol
>> 'i945gm_vblank_work_func' was not declared. Should it be static?
>>
>> Make the function static again.
>>
>> Fixes: 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs")
>> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> 3 people (well 2 and a robot) send patches for the same compiler
> warning! That means something, right?
That writing patches is more rewarding than reading patches written by
others...? ;)
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Thanks, likewise, let's see whose patch passes CI first. Looks like your
patch regresses module reload. :D
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
