Re: [PATCH 2/2] drm/i915: add header search path to subdir Makefiles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jani Nikula (2019-06-26 15:36:18)
> With the subdirectories we lost the ability to build individual files on
> the command line, for example:
> 
> $ make drivers/gpu/drm/i915/display/intel_display.o
> 
> This was due to the top level directory missing from header search
> path. Add the header search paths to subdir Makefiles.
> 
> Note that none of the other options in the top level i915 Makefile are
> taken into account when building individual files. Usually this is not a
> concern.
> 
> Reported-by: Imre Deak <imre.deak@xxxxxxxxx>
> Reported-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/display/Makefile | 3 +++
>  drivers/gpu/drm/i915/gem/Makefile     | 6 +++++-
>  drivers/gpu/drm/i915/gt/Makefile      | 3 +++
>  3 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/Makefile b/drivers/gpu/drm/i915/display/Makefile
> index 1c75b5c9790c..eec6961015a1 100644
> --- a/drivers/gpu/drm/i915/display/Makefile
> +++ b/drivers/gpu/drm/i915/display/Makefile
> @@ -1,2 +1,5 @@
> +# For building individual subdir files on the command line
> +subdir-ccflags-y += -I$(srctree)/$(src)/..

We could stick it in a common header.include but here's hoping this is
all replaced by something better,

Reviewed-by Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux