On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote:
> Currently we restrict the number of encoders that can be linked to
> a connector to 3, increase it to match the maximum number of encoders
> that can be initialized - 32. The current limitation looks artificial.
> Increasing the limit to 32 does however increases the size of the static
> u32 array keeping track of the encoder IDs.
>
> Cc: José Roberto de Souza <jose.souza@xxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
> ---
> include/drm/drm_connector.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index ca745d9feaf5..91455b4a9360 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1278,7 +1278,7 @@ struct drm_connector {
> /** @override_edid: has the EDID been overwritten through debugfs for testing? */
> bool override_edid;
>
> -#define DRM_CONNECTOR_MAX_ENCODER 3
> +#define DRM_CONNECTOR_MAX_ENCODER 32
> /**
> * @encoder_ids: Valid encoders for this connector. Please only use
> * drm_connector_for_each_possible_encoder() to enumerate these.
I wonder if we couldn't just replace this array with a bitmask?
I think the for_each_possible_encoder() thing I did a while back
should make this easier potentially because most driver code just
uses that.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
