== Series Details == Series: EHL port programming (rev3) URL : https://patchwork.freedesktop.org/series/62492/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1ef07c06355c drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC") -:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")' #10: References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC") total: 1 errors, 1 warnings, 0 checks, 36 lines checked a737be214a1b drm/i915/ehl: Add third combo PHY offset f52bd63ed2e0 drm/i915/ehl: Don't program PHY_MISC on EHL PHY C 1d39822bbc7c drm/i915/gen11: Start distinguishing 'phy' from 'port' -:182: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects? #182: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:9: +#define for_each_combo_phy(__dev_priv, __phy) \ + for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++) \ + for_each_if(intel_phy_is_combo(__dev_priv, __phy)) -:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects? #189: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:13: +#define for_each_combo_phy_reverse(__dev_priv, __phy) \ + for ((__phy) = I915_MAX_PHYS; (__phy)-- > PHY_A;) \ + for_each_if(intel_phy_is_combo(__dev_priv, __phy)) -:1021: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects? #1021: FILE: drivers/gpu/drm/i915/i915_reg.h:9692: +#define ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port) (1 << ((tc_port) == PORT_TC4 ? \ + 21 : (tc_port) + 12)) -:1024: WARNING:LONG_LINE: line over 100 characters #1024: FILE: drivers/gpu/drm/i915/i915_reg.h:9695: +#define ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy) (3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)) -:1025: WARNING:LONG_LINE: line over 100 characters #1025: FILE: drivers/gpu/drm/i915/i915_reg.h:9696: +#define ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy) ((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)) total: 0 errors, 2 warnings, 3 checks, 879 lines checked 823c40cd4f30 drm/i915/ehl: Enable DDI-D _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
