On Fri, 11 May 2012 11:00:12 +0200, Daniel Vetter <daniel at ffwll.ch> wrote: > On Thu, May 10, 2012 at 03:39:32PM -0700, Ben Widawsky wrote: > > Sneaky way to get rid of the warning you never liked... I won't forget > > this. > > I concur that killing that warnings is sneaky ;-) Can't we just keep them > - the ring->obj check should do the right thing? Or what exactly do I > miss? Other than I'm not a fan of those warnings; completely in the wrong spot. If you want a warning that i915_gpu_idle is not doing its job even in the face of a wedged GPU (so in fact i915_gem_reset failing), it would be better to place those warnings inside i915_gpu_idle. -Chris -- Chris Wilson, Intel Open Source Technology Centre
