Quoting Daniele Ceraolo Spurio (2019-06-25 21:06:10) > > > On 6/25/19 11:47 AM, Chris Wilson wrote: > > Do we even need to dump them? They are almost all static, with the > > exception of debug level and ads address? Is it useful? > > In my experience it can be useful when we get a bug report where guc > failed to load or when we're testing an interface change to double-check > that the parameters are set as expected. But I agree there is no need to > dump all the dwords we don't set. Maybe we can reduce GUC_CTL_MAX_DWORDS > to the number of used dwords, or add a new define set to that and use it > for buf size? If you have used them, then by definition they are useful :) If you know when you need the information, e.g. the init sequence failed; then dump then? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
