Re: [PATCH v2] drm/i915: Refine eDP aux backlight enable/disable sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Jun 2019, Lee Shawn C <shawn.c.lee@xxxxxxxxx> wrote:
>
>Modify aux backlight enable/disable sequence just like what we did for genernal eDP panel.
>1. Setup PWM freq and brightness level before enable display backlight.
>2. Set PWM to 0 after backlight enable was off.
>
>v2: Code structure was changed. Modify this patch to align the latest.
>
>Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
>Cc: Jose Roberto de Souza <jose.souza@xxxxxxxxx>
>Cc: Cooper Chiou <cooper.chiou@xxxxxxxxx>
>
>Signed-off-by: Lee Shawn C <shawn.c.lee@xxxxxxxxx>
>---
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>index 6b0b73479fb8..bbc579734238 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
>@@ -216,13 +216,14 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
> 		}
> 	}
> 
>-	set_aux_backlight_enable(intel_dp, true);
> 	intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
>+	set_aux_backlight_enable(intel_dp, true);
> }
> 
> static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)  {
> 	set_aux_backlight_enable(enc_to_intel_dp(old_conn_state->best_encoder), false);
>+	intel_dp_aux_set_backlight(old_conn_state, 0);
> }
> 
> static int intel_dp_aux_setup_backlight(struct intel_connector *connector,
>--
>2.7.4
>

Please ignore this series change. I will push a new one instead of this series. 
Because of we don't need the change from patch #2 that applied unnecessary delay.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux