== Series Details == Series: Split hw and drm state. URL : https://patchwork.freedesktop.org/series/62485/ State : warning == Summary == $ dim checkpatch origin/drm-tip 43159ab9270f drm/i915: Pass intel_crtc_state to needs_modeset() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 231 lines checked 10743f477195 drm/i915: Convert most of atomic commit to take more intel state -:380: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #380: FILE: drivers/gpu/drm/i915/display/intel_display.c:6675: + crtc->enabled_power_domains = new_domains = -:682: WARNING:LONG_LINE: line over 100 characters #682: FILE: drivers/gpu/drm/i915/display/intel_display.c:13647: + for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) { total: 0 errors, 1 warnings, 1 checks, 985 lines checked c6a1846ce000 drm/i915: Convert hw state verifier to take more intel state -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:27: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #27: FILE: drivers/gpu/drm/i915/display/intel_display.c:6999: + I915_STATE_WARN(!crtc_state->base.active, "connector is active, but attached crtc isn't\n"); -:36: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #36: FILE: drivers/gpu/drm/i915/display/intel_display.c:7011: + I915_STATE_WARN(crtc_state && crtc_state->base.active, "attached crtc is active, but connector isn't\n"); -:199: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #199: FILE: drivers/gpu/drm/i915/display/intel_display.c:12939: + I915_STATE_WARN(new_crtc_state->base.active != active, "crtc active state doesn't match with hw state " -:205: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #205: FILE: drivers/gpu/drm/i915/display/intel_display.c:12943: + I915_STATE_WARN(crtc->active != new_crtc_state->base.active, "transitional active state does not match atomic hw state " -:216: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #216: FILE: drivers/gpu/drm/i915/display/intel_display.c:12951: + I915_STATE_WARN(active != new_crtc_state->base.active, "[ENCODER:%i] active %i with crtc active %i\n", -:297: WARNING:LONG_LINE: line over 100 characters #297: FILE: drivers/gpu/drm/i915/display/intel_display.c:13053: + verify_single_dpll_state(dev_priv, new_crtc_state->shared_dpll, crtc, new_crtc_state); total: 0 errors, 2 warnings, 5 checks, 337 lines checked ade264d7f94f drm/i915: Use intel_crtc_state in sanitize_watermarks() too -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 27 lines checked 8d0923e49528 drm/i915: Pass intel state to plane functions as well -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:154: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #154: FILE: drivers/gpu/drm/i915/display/intel_display.c:11358: + plane_state->base.visible = visible = false; total: 0 errors, 1 warnings, 1 checks, 196 lines checked cf6478f30379 drm/i915: Use intel state as much as possible in wm code e80bd07d6220 drm/i915: Prepare to split crtc state in uapi and hw state -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: - crtc, *_changed flags, event, commit, state, mode_blob, (plane/connector/encoder)_mask. -:1950: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1950: FILE: drivers/gpu/drm/i915/display/intel_display.c:11011: + crtc_state->uapi.active = crtc_state->uapi.enable = true; -:2607: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #2607: FILE: drivers/gpu/drm/i915/display/intel_display.c:16437: + crtc_state->hw.active = crtc_state->hw.enable = -:3778: ERROR:CODE_INDENT: code indent should use tabs where possible #3778: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:223: +^I^I^I^I new_crtc_state->uapi.event);$ -:3778: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #3778: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:223: + drm_crtc_arm_vblank_event(&crtc->base, + new_crtc_state->uapi.event); total: 1 errors, 1 warnings, 3 checks, 4207 lines checked 24ddbe924837 drm/i915: Handle a few more cases for hw/sw split -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 118 lines checked fd5e35bacee3 drm/i915: Complete sw/hw split -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 173 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
