Quoting Chris Wilson (2019-06-18 14:59:02) > Quoting Mika Kuoppala (2019-06-18 14:45:45) > > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > > > @@ -328,6 +345,7 @@ void i915_active_acquire_barrier(struct i915_active *ref) > > > > > > llist_add((struct llist_node *)&node->base.link, > > > &engine->barrier_tasks); > > > + intel_engine_pm_put(engine); > > > > But you said that you keep the wakeref until unpin? > > intel_context_unpin -> > intel_context_active_release -> > i915_active_acquire_barrier That should probably be renamed to i915_active_release_barrier. Possibly, something even more imaginative. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx