== Series Details == Series: series starting with [01/26] drm/i915: Keep engine alive as we retire the context URL : https://patchwork.freedesktop.org/series/62278/ State : warning == Summary == $ dim checkpatch origin/drm-tip cda76c80993d drm/i915: Keep engine alive as we retire the context 42021f601d33 drm/i915: Skip shrinking already freed pages ab6a6e6954bf drm/i915: Stop passing I915_WAIT_LOCKED to i915_request_wait() -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: References: eb8d0f5af4ec ("drm/i915: Remove GPU reset dependence on struct_mutex") -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit eb8d0f5af4ec ("drm/i915: Remove GPU reset dependence on struct_mutex")' #11: References: eb8d0f5af4ec ("drm/i915: Remove GPU reset dependence on struct_mutex") total: 1 errors, 1 warnings, 0 checks, 328 lines checked 145d0e3ed4ef drm/i915: Flush the execution-callbacks on retiring 78b85c062e30 drm/i915/execlists: Preempt-to-busy -:1494: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects? #1494: FILE: drivers/gpu/drm/i915/i915_utils.h:134: +#define ptr_count_dec(p_ptr) do { \ + typeof(p_ptr) __p = (p_ptr); \ + unsigned long __v = (unsigned long)(*__p); \ + *__p = (typeof(*p_ptr))(--__v); \ +} while (0) -:1500: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects? #1500: FILE: drivers/gpu/drm/i915/i915_utils.h:140: +#define ptr_count_inc(p_ptr) do { \ + typeof(p_ptr) __p = (p_ptr); \ + unsigned long __v = (unsigned long)(*__p); \ + *__p = (typeof(*p_ptr))(++__v); \ +} while (0) -:1783: WARNING:LINE_SPACING: Missing a blank line after declarations #1783: FILE: drivers/gpu/drm/i915/intel_guc_submission.c:820: + int rem = ARRAY_SIZE(execlists->inflight) - idx; + memmove(execlists->inflight, port, rem * sizeof(*port)); total: 0 errors, 1 warnings, 2 checks, 1682 lines checked 71d1fe05be01 drm/i915/execlists: Minimalistic timeslicing -:345: WARNING:LONG_LINE: line over 100 characters #345: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:211: + 2 * RUNTIME_INFO(outer->i915)->num_engines * (count + 2) * (count + 3)) < 0) { total: 0 errors, 1 warnings, 0 checks, 426 lines checked 40741878cefb drm/i915/execlists: Force preemption e42940af0600 drm/i915: Make the semaphore saturation mask global 913184b36dae dma-fence: Propagate errors to dma-fence-array container fbc685fee7cf dma-fence: Report the composite sync_file status d2298deb220a dma-fence: Refactor signaling for manual invocation -:33: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 -:38: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #38: FILE: drivers/dma-buf/dma-fence-trace.c:1: +/* -:293: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #293: FILE: include/linux/dma-fence-types.h:1: +/* -:368: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #368: FILE: include/linux/dma-fence-types.h:76: + spinlock_t *lock; total: 0 errors, 3 warnings, 1 checks, 728 lines checked fe5ceef08681 dma-fence: Always execute signal callbacks e6baddc16878 drm/i915: Track i915_active using debugobjects 626786997753 drm/i915: Signal fence completion from i915_request_wait d80318d1c748 drm/i915: Remove waiting & retiring from shrinker paths 8b858b38bcfc drm/i915: Throw away the active object retirement complexity c38757f3f210 drm/i915: Provide an i915_active.acquire callback -:708: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #708: FILE: drivers/gpu/drm/i915/i915_active_types.h:36: + struct mutex mutex; total: 0 errors, 0 warnings, 1 checks, 842 lines checked 6b856a93ddbf drm/i915: Push the i915_active.retire into a worker babae9b85e46 drm/i915/overlay: Switch to using i915_active tracking 295efee4f1d6 drm/i915: Forgo last_fence active request tracking 044650684354 drm/i915: Extract intel_frontbuffer active tracking 1ba725af6d0c drm/i915: Coordinate i915_active with its own mutex 962860b4976d drm/i915: Rename intel_wakeref_[is]_active b1132180c60a drm/i915: Teach execbuffer to take the engine wakeref not GT 38774404475a drm/i915: Replace struct_mutex for batch pool serialisation -:304: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #304: new file mode 100644 -:309: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #309: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1: +/* -:310: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2: + * SPDX-License-Identifier: MIT -:478: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #478: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1: +/* -:479: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #479: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2: + * SPDX-License-Identifier: MIT -:517: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #517: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1: +/* -:518: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #518: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2: + * SPDX-License-Identifier: MIT -:534: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #534: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18: + spinlock_t lock; total: 0 errors, 7 warnings, 1 checks, 589 lines checked cc4a2f29f9fe drm/i915: Move idle barrier cleanup into engine-pm _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx