== Series Details == Series: Display uncore prep patches URL : https://patchwork.freedesktop.org/series/62232/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2803e5056bc3 drm/i915: use vfuncs for reg_read/write_fw_domains -:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #61: FILE: drivers/gpu/drm/i915/intel_uncore.c:1155: +#define __gen_reg_read_funcs(func) \ +static enum forcewake_domains \ +func##_reg_read_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \ + return __##func##_reg_read_fw_domains(uncore, i915_mmio_reg_offset(reg)); \ +} \ +\ +__gen_read(func, 8) \ +__gen_read(func, 16) \ +__gen_read(func, 32) \ +__gen_read(func, 64) -:84: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #84: FILE: drivers/gpu/drm/i915/intel_uncore.c:1231: } +__gen6_write(8) -:115: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #115: FILE: drivers/gpu/drm/i915/intel_uncore.c:1247: +#define __gen_reg_write_funcs(func) \ +static enum forcewake_domains \ +func##_reg_write_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \ + return __##func##_reg_write_fw_domains(uncore, i915_mmio_reg_offset(reg)); \ +} \ +\ +__gen_write(func, 8) \ +__gen_write(func, 16) \ +__gen_write(func, 32) -:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #134: FILE: drivers/gpu/drm/i915/intel_uncore.c:1265: +#define ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, x) \ do { \ (uncore)->funcs.mmio_writeb = x##_write8; \ (uncore)->funcs.mmio_writew = x##_write16; \ (uncore)->funcs.mmio_writel = x##_write32; \ } while (0) -:142: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #142: FILE: drivers/gpu/drm/i915/intel_uncore.c:1272: +#define ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x) \ do { \ (uncore)->funcs.mmio_readb = x##_read8; \ (uncore)->funcs.mmio_readw = x##_read16; \ -:150: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #150: FILE: drivers/gpu/drm/i915/intel_uncore.c:1280: +#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \ +do { \ + ASSIGN_RAW_WRITE_MMIO_VFUNCS((uncore), x); \ + (uncore)->funcs.write_fw_domains = x##_reg_write_fw_domains; \ +} while (0) -:156: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #156: FILE: drivers/gpu/drm/i915/intel_uncore.c:1286: +#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \ +do { \ + ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x); \ + (uncore)->funcs.read_fw_domains = x##_reg_read_fw_domains; \ +} while (0) total: 0 errors, 0 warnings, 7 checks, 258 lines checked 028d6e2ee6b1 drm/i915: kill uncore_sanitize 5b00f7cabec2 drm/i915: kill uncore_to_i915 e4dd10b092d7 drm/i915: skip forcewake actions on forcewake-less uncore -:86: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #86: FILE: drivers/gpu/drm/i915/intel_uncore.c:489: +static void forcewake_early_sanitize(struct intel_uncore *uncore, unsigned int restore_forcewake) -:314: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #314: FILE: drivers/gpu/drm/i915/intel_uncore.c:1689: + iosf_mbi_unregister_pmic_bus_access_notifier_unlocked( total: 0 errors, 0 warnings, 2 checks, 302 lines checked 769ba7ddece2 drm/i915: dynamically allocate forcewake domains -:32: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #32: FILE: drivers/gpu/drm/i915/intel_uncore.c:1295: +static int fw_domain_init(struct intel_uncore *uncore, enum forcewake_domain_id domain_id, -:115: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #115: FILE: drivers/gpu/drm/i915/intel_uncore.c:1374: +#define __fw_domain_init(id__, set__, ack__) \ + ret = fw_domain_init(uncore, (id__), (set__), (ack__)); \ + if (ret) \ + goto out_clean; -:115: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #115: FILE: drivers/gpu/drm/i915/intel_uncore.c:1374: +#define __fw_domain_init(id__, set__, ack__) \ + ret = fw_domain_init(uncore, (id__), (set__), (ack__)); \ + if (ret) \ + goto out_clean; -:115: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #115: FILE: drivers/gpu/drm/i915/intel_uncore.c:1374: +#define __fw_domain_init(id__, set__, ack__) \ + ret = fw_domain_init(uncore, (id__), (set__), (ack__)); \ + if (ret) \ + goto out_clean; total: 1 errors, 2 warnings, 1 checks, 321 lines checked 87b897489919 drm/i915/gvt: decouple check_vgpu() from uncore_init() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
