Re: [RFC 16/28] drm/i915: Compartmentalize i915_ggtt_probe_hw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 14/06/2019 11:23, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-06-14 10:35:57)

On 13/06/2019 15:03, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-06-13 14:35:27)
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Having made start to better code compartmentalization by introducing
struct intel_gt, continue the theme elsewhere in code by making functions
take parameters take what logically makes most sense for them instead of
the global struct drm_i915_private.

Is that a can of worms I see? :)

While you are here, care to pull in the gmch probe so we can drop the
frankenstein approach.

What exactly do you mean? Pull in what from where to where?

intel_gtt.ko is the other half of i915_gem_gtt.c

I'll leave this out of this series, at least for now.

Otherwise I've done all the other refactors and tweaks to higher or lower standard. I'll send a new RFC out just so we see where we are.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux