== Series Details == Series: gpu/drm/i915: globally replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/61983/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5585dfe286e9 gpu/drm/i915: globally replace dev_priv with i915 -:633: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!r" #633: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:141: + if (r == NULL && !IS_GEN(i915, 3)) { -:2243: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2243: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:909: + if (IS_GEN(gvt->i915, 9) && intel_gvt_mmio_is_in_ctx(gvt, offset) && -:2863: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2863: FILE: drivers/gpu/drm/i915/gvt/gtt.c:293: +static void write_pte64(struct drm_i915_private *i915, unsigned long index, u64 pte) -:3109: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues #3109: FILE: drivers/gpu/drm/i915/gvt/gvt.h:376: +#define gvt_aperture_sz(gvt) (gvt->i915->ggtt.mappable_end) -:3110: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues #3110: FILE: drivers/gpu/drm/i915/gvt/gvt.h:377: +#define gvt_aperture_pa_base(gvt) (gvt->i915->ggtt.gmadr.start) -:3113: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues #3113: FILE: drivers/gpu/drm/i915/gvt/gvt.h:379: +#define gvt_ggtt_gm_sz(gvt) (gvt->i915->ggtt.vm.total) -:3125: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues #3125: FILE: drivers/gpu/drm/i915/gvt/gvt.h:393: +#define gvt_fence_sz(gvt) (gvt->i915->num_fence_regs) -:3309: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3309: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1420: + if (IS_SKYLAKE(vgpu->gvt->i915) + || IS_KABYLAKE(vgpu->gvt->i915) -:3310: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3310: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1421: + || IS_KABYLAKE(vgpu->gvt->i915) + || IS_COFFEELAKE(vgpu->gvt->i915)) { -:3331: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3331: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1445: + if (IS_SKYLAKE(vgpu->gvt->i915) + || IS_KABYLAKE(vgpu->gvt->i915) -:3332: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3332: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1446: + || IS_KABYLAKE(vgpu->gvt->i915) + || IS_COFFEELAKE(vgpu->gvt->i915)) -:3457: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3457: FILE: drivers/gpu/drm/i915/gvt/handlers.c:3364: + } else if (IS_SKYLAKE(i915) + || IS_KABYLAKE(i915) -:3458: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #3458: FILE: drivers/gpu/drm/i915/gvt/handlers.c:3365: + || IS_KABYLAKE(i915) + || IS_COFFEELAKE(i915)) { -:3919: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #3919: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1019: + intel_uncore_forcewake_get(&gvt->i915->uncore, FORCEWAKE_ALL); -:3928: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #3928: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1041: + intel_uncore_forcewake_put(&gvt->i915->uncore, FORCEWAKE_ALL); -:4443: CHECK:BRACES: braces {} should be used on all arms of this statement #4443: FILE: drivers/gpu/drm/i915/i915_debugfs.c:907: + if (INTEL_GEN(i915) >= 9) [...] else { [...] -:4959: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63) #4959: FILE: drivers/gpu/drm/i915/i915_debugfs.c:1496: + if (INTEL_GEN(i915) >= 9) /* no global SR status; inspect per-plane WM */; -:7255: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!i915->wq" #7255: FILE: drivers/gpu/drm/i915/i915_drv.c:819: + if (i915->wq == NULL) -:7261: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!i915->hotplug.dp_wq" #7261: FILE: drivers/gpu/drm/i915/i915_drv.c:823: + if (i915->hotplug.dp_wq == NULL) -:8663: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #8663: FILE: drivers/gpu/drm/i915/i915_drv.c:2857: +static int vlv_resume_prepare(struct drm_i915_private *i915, bool rpm_resume) -:9173: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9173: FILE: drivers/gpu/drm/i915/i915_drv.h:2176: +#define IS_G4X(i915) (IS_G45(i915) || IS_GM45(i915)) -:9177: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9177: FILE: drivers/gpu/drm/i915/i915_drv.h:2180: +#define IS_IRONLAKE_M(i915) \ + (IS_PLATFORM(i915, INTEL_IRONLAKE) && IS_MOBILE(i915)) -:9180: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9180: FILE: drivers/gpu/drm/i915/i915_drv.h:2183: +#define IS_IVB_GT1(i915) (IS_IVYBRIDGE(i915) && \ + INTEL_INFO(i915)->gt == 1) -:9194: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9194: FILE: drivers/gpu/drm/i915/i915_drv.h:2197: +#define IS_HSW_EARLY_SDV(i915) (IS_HASWELL(i915) && \ + (INTEL_DEVID(i915) & 0xFF00) == 0x0C00) -:9200: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9200: FILE: drivers/gpu/drm/i915/i915_drv.h:2203: +#define IS_BDW_GT3(i915) (IS_BROADWELL(i915) && \ + INTEL_INFO(i915)->gt == 3) -:9204: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9204: FILE: drivers/gpu/drm/i915/i915_drv.h:2207: +#define IS_HSW_GT3(i915) (IS_HASWELL(i915) && \ + INTEL_INFO(i915)->gt == 3) -:9206: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9206: FILE: drivers/gpu/drm/i915/i915_drv.h:2209: +#define IS_HSW_GT1(i915) (IS_HASWELL(i915) && \ + INTEL_INFO(i915)->gt == 1) -:9251: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9251: FILE: drivers/gpu/drm/i915/i915_drv.h:2222: +#define IS_SKL_GT2(i915) (IS_SKYLAKE(i915) && \ + INTEL_INFO(i915)->gt == 2) -:9253: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9253: FILE: drivers/gpu/drm/i915/i915_drv.h:2224: +#define IS_SKL_GT3(i915) (IS_SKYLAKE(i915) && \ + INTEL_INFO(i915)->gt == 3) -:9255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9255: FILE: drivers/gpu/drm/i915/i915_drv.h:2226: +#define IS_SKL_GT4(i915) (IS_SKYLAKE(i915) && \ + INTEL_INFO(i915)->gt == 4) -:9257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9257: FILE: drivers/gpu/drm/i915/i915_drv.h:2228: +#define IS_KBL_GT2(i915) (IS_KABYLAKE(i915) && \ + INTEL_INFO(i915)->gt == 2) -:9259: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9259: FILE: drivers/gpu/drm/i915/i915_drv.h:2230: +#define IS_KBL_GT3(i915) (IS_KABYLAKE(i915) && \ + INTEL_INFO(i915)->gt == 3) -:9265: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9265: FILE: drivers/gpu/drm/i915/i915_drv.h:2236: +#define IS_CFL_GT2(i915) (IS_COFFEELAKE(i915) && \ + INTEL_INFO(i915)->gt == 2) -:9267: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9267: FILE: drivers/gpu/drm/i915/i915_drv.h:2238: +#define IS_CFL_GT3(i915) (IS_COFFEELAKE(i915) && \ + INTEL_INFO(i915)->gt == 3) -:9282: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9282: FILE: drivers/gpu/drm/i915/i915_drv.h:2262: +#define IS_BXT_REVID(i915, since, until) \ + (IS_BROXTON(i915) && IS_REVID(i915, since, until)) -:9293: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9293: FILE: drivers/gpu/drm/i915/i915_drv.h:2271: +#define IS_KBL_REVID(i915, since, until) \ + (IS_KABYLAKE(i915) && IS_REVID(i915, since, until)) -:9301: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9301: FILE: drivers/gpu/drm/i915/i915_drv.h:2277: +#define IS_GLK_REVID(i915, since, until) \ + (IS_GEMINILAKE(i915) && IS_REVID(i915, since, until)) -:9314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9314: FILE: drivers/gpu/drm/i915/i915_drv.h:2297: +#define IS_GEN9_LP(i915) (IS_GEN(i915, 9) && IS_LP(i915)) -:9315: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9315: FILE: drivers/gpu/drm/i915/i915_drv.h:2298: +#define IS_GEN9_BC(i915) (IS_GEN(i915, 9) && !IS_LP(i915)) -:9365: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9365: FILE: drivers/gpu/drm/i915/i915_drv.h:2316: +#define HAS_WT(i915) ((IS_HASWELL(i915) || \ + IS_BROADWELL(i915)) && HAS_EDRAM(i915)) -:9385: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sizes' - possible side-effects? #9385: FILE: drivers/gpu/drm/i915/i915_drv.h:2336: +#define HAS_PAGE_SIZES(i915, sizes) ({ \ GEM_BUG_ON((sizes) == 0); \ + ((sizes) & ~INTEL_INFO(i915)->page_sizes) == 0; \ }) -:9400: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9400: FILE: drivers/gpu/drm/i915/i915_drv.h:2346: +#define HAS_BROKEN_CS_TLB(i915) (IS_I830(i915) || IS_I845G(i915)) -:9406: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9406: FILE: drivers/gpu/drm/i915/i915_drv.h:2349: +#define NEEDS_WaRsDisableCoarsePowerGating(i915) \ + (IS_CANNONLAKE(i915) || \ + IS_SKL_GT3(i915) || IS_SKL_GT4(i915)) -:9415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9415: FILE: drivers/gpu/drm/i915/i915_drv.h:2354: +#define HAS_GMBUS_BURST_READ(i915) (INTEL_GEN(i915) >= 10 || \ + IS_GEMINILAKE(i915) || \ + IS_KABYLAKE(i915)) -:9427: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9427: FILE: drivers/gpu/drm/i915/i915_drv.h:2361: +#define HAS_128_BYTE_Y_TILING(i915) (!IS_GEN(i915, 2) && \ + !(IS_I915G(i915) || \ + IS_I915GM(i915))) -:9436: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9436: FILE: drivers/gpu/drm/i915/i915_drv.h:2367: +#define HAS_FW_BLC(i915) ^I(INTEL_GEN(i915) > 2)$ -:9438: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9438: FILE: drivers/gpu/drm/i915/i915_drv.h:2369: +#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && INTEL_GEN(i915) >= 7) -:9441: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9441: FILE: drivers/gpu/drm/i915/i915_drv.h:2371: +#define HAS_IPS(i915) (IS_HSW_ULT(i915) || IS_BROADWELL(i915)) -:9537: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9537: FILE: drivers/gpu/drm/i915/i915_drv.h:2438: +#define HAS_PCH_LPT_LP(i915) \ + (INTEL_PCH_ID(i915) == INTEL_PCH_LPT_LP_DEVICE_ID_TYPE || \ + INTEL_PCH_ID(i915) == INTEL_PCH_WPT_LP_DEVICE_ID_TYPE) -:9540: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9540: FILE: drivers/gpu/drm/i915/i915_drv.h:2441: +#define HAS_PCH_LPT_H(i915) \ + (INTEL_PCH_ID(i915) == INTEL_PCH_LPT_DEVICE_ID_TYPE || \ + INTEL_PCH_ID(i915) == INTEL_PCH_WPT_DEVICE_ID_TYPE) -:9557: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #9557: FILE: drivers/gpu/drm/i915/i915_drv.h:2455: +#define NUM_L3_SLICES(i915) (IS_HSW_GT3(i915) ? \ + 2 : HAS_L3_DPF(i915)) -:9606: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9606: FILE: drivers/gpu/drm/i915/i915_drv.h:2506: +extern void intel_hangcheck_init(struct drm_i915_private *i915); -:9802: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9802: FILE: drivers/gpu/drm/i915/i915_drv.h:2799: +extern void i915_perf_init(struct drm_i915_private *i915); -:9803: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9803: FILE: drivers/gpu/drm/i915/i915_drv.h:2800: +extern void i915_perf_fini(struct drm_i915_private *i915); -:9804: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9804: FILE: drivers/gpu/drm/i915/i915_drv.h:2801: +extern void i915_perf_register(struct drm_i915_private *i915); -:9805: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9805: FILE: drivers/gpu/drm/i915/i915_drv.h:2802: +extern void i915_perf_unregister(struct drm_i915_private *i915); -:9810: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9810: FILE: drivers/gpu/drm/i915/i915_drv.h:2805: +extern int i915_save_state(struct drm_i915_private *i915); -:9811: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9811: FILE: drivers/gpu/drm/i915/i915_drv.h:2806: +extern int i915_restore_state(struct drm_i915_private *i915); -:9833: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9833: FILE: drivers/gpu/drm/i915/i915_drv.h:2823: +extern int intel_modeset_vga_set_state(struct drm_i915_private *i915, -:9839: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9839: FILE: drivers/gpu/drm/i915/i915_drv.h:2826: +extern void i915_redisable_vga(struct drm_i915_private *i915); -:9840: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9840: FILE: drivers/gpu/drm/i915/i915_drv.h:2827: +extern void i915_redisable_vga_power_on(struct drm_i915_private *i915); -:9841: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9841: FILE: drivers/gpu/drm/i915/i915_drv.h:2828: +extern void intel_init_pch_refclk(struct drm_i915_private *i915); -:10147: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #10147: FILE: drivers/gpu/drm/i915/i915_gem.c:1284: + BUG_ON(!i915->kernel_context); -:12501: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #12501: FILE: drivers/gpu/drm/i915/i915_irq.c:1464: + i915->l3_parity.which_slice &= ~(1<<slice); ^ -:14642: WARNING:BRACES: braces {} are not necessary for any arm of this statement #14642: FILE: drivers/gpu/drm/i915/i915_irq.c:3984: + if (IS_GEN(i915, 5)) { [...] } else { [...] -:14879: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #14879: FILE: drivers/gpu/drm/i915/i915_irq.c:4187: + if (intel_display_power_is_enabled(i915, POWER_DOMAIN_PIPE(pipe))) -:15739: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #15739: FILE: drivers/gpu/drm/i915/i915_irq.h:16: +extern void intel_irq_init(struct drm_i915_private *i915); -:15740: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #15740: FILE: drivers/gpu/drm/i915/i915_irq.h:17: +extern void intel_irq_fini(struct drm_i915_private *i915); -:15785: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #15785: FILE: drivers/gpu/drm/i915/i915_irq.h:50: } +void bdw_update_pipe_irq(struct drm_i915_private *i915, -:15797: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #15797: FILE: drivers/gpu/drm/i915/i915_irq.h:59: } +static inline void bdw_disable_pipe_irq(struct drm_i915_private *i915, -:15804: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #15804: FILE: drivers/gpu/drm/i915/i915_irq.h:64: } +void ibx_display_interrupt_update(struct drm_i915_private *i915, -:15949: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #15949: FILE: drivers/gpu/drm/i915/i915_oa_bdw.h:13: +extern void i915_perf_load_test_config_bdw(struct drm_i915_private *i915); -:16010: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16010: FILE: drivers/gpu/drm/i915/i915_oa_bxt.h:13: +extern void i915_perf_load_test_config_bxt(struct drm_i915_private *i915); -:16071: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16071: FILE: drivers/gpu/drm/i915/i915_oa_cflgt2.h:13: +extern void i915_perf_load_test_config_cflgt2(struct drm_i915_private *i915); -:16132: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16132: FILE: drivers/gpu/drm/i915/i915_oa_cflgt3.h:13: +extern void i915_perf_load_test_config_cflgt3(struct drm_i915_private *i915); -:16193: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16193: FILE: drivers/gpu/drm/i915/i915_oa_chv.h:13: +extern void i915_perf_load_test_config_chv(struct drm_i915_private *i915); -:16254: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16254: FILE: drivers/gpu/drm/i915/i915_oa_cnl.h:13: +extern void i915_perf_load_test_config_cnl(struct drm_i915_private *i915); -:16315: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16315: FILE: drivers/gpu/drm/i915/i915_oa_glk.h:13: +extern void i915_perf_load_test_config_glk(struct drm_i915_private *i915); -:16376: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16376: FILE: drivers/gpu/drm/i915/i915_oa_hsw.h:13: +extern void i915_perf_load_test_config_hsw(struct drm_i915_private *i915); -:16437: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16437: FILE: drivers/gpu/drm/i915/i915_oa_icl.h:13: +extern void i915_perf_load_test_config_icl(struct drm_i915_private *i915); -:16498: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16498: FILE: drivers/gpu/drm/i915/i915_oa_kblgt2.h:13: +extern void i915_perf_load_test_config_kblgt2(struct drm_i915_private *i915); -:16559: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16559: FILE: drivers/gpu/drm/i915/i915_oa_kblgt3.h:13: +extern void i915_perf_load_test_config_kblgt3(struct drm_i915_private *i915); -:16620: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16620: FILE: drivers/gpu/drm/i915/i915_oa_sklgt2.h:13: +extern void i915_perf_load_test_config_sklgt2(struct drm_i915_private *i915); -:16681: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16681: FILE: drivers/gpu/drm/i915/i915_oa_sklgt3.h:13: +extern void i915_perf_load_test_config_sklgt3(struct drm_i915_private *i915); -:16742: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #16742: FILE: drivers/gpu/drm/i915/i915_oa_sklgt4.h:13: +extern void i915_perf_load_test_config_sklgt4(struct drm_i915_private *i915); -:16990: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i915->perf.oa.oa_buffer.last_ctx_id == i915->perf.oa.specific_ctx_id' #16990: FILE: drivers/gpu/drm/i915/i915_perf.c:788: + if (!i915->perf.oa.exclusive_stream->ctx || + i915->perf.oa.specific_ctx_id == ctx_id || + (i915->perf.oa.oa_buffer.last_ctx_id == + i915->perf.oa.specific_ctx_id) || reason & OAREPORT_REASON_CTX_SWITCH) { -:17259: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #17259: FILE: drivers/gpu/drm/i915/i915_perf.c:1364: + BUG_ON(stream != i915->perf.oa.exclusive_stream); -:17925: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #17925: FILE: drivers/gpu/drm/i915/i915_perf.c:2326: +static __poll_t i915_perf_poll_locked(struct drm_i915_private *i915, struct i915_perf_stream *stream, -:18638: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #18638: FILE: drivers/gpu/drm/i915/i915_perf.c:3464: + i915->perf.oa.gen8_valid_ctx_bit = (1<<25); ^ -:18646: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #18646: FILE: drivers/gpu/drm/i915/i915_perf.c:3469: + i915->perf.oa.gen8_valid_ctx_bit = (1<<16); ^ -:18671: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #18671: FILE: drivers/gpu/drm/i915/i915_perf.c:3485: + i915->perf.oa.gen8_valid_ctx_bit = (1<<16); ^ -:18679: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #18679: FILE: drivers/gpu/drm/i915/i915_perf.c:3491: + hrtimer_init(&i915->perf.oa.poll_check_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); -:18914: WARNING:LONG_LINE: line over 100 characters #18914: FILE: drivers/gpu/drm/i915/i915_reg.h:254: + _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
