On Tue, Jun 04, 2019 at 12:36:46PM -0700, Manasi Navare wrote: > On Tue, Jun 04, 2019 at 05:02:14PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > intel_dp_link_down() is static and it's only called from the pre-ddi > > DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless. > > Remove it. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Looks good to me, > > Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> Thanks for the review. Series pushed to dinq. > > Manasi > > > --- > > drivers/gpu/drm/i915/intel_dp.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > index 64fefc9af7a6..764e54fef5ee 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -3994,9 +3994,6 @@ intel_dp_link_down(struct intel_encoder *encoder, > > enum port port = encoder->port; > > u32 DP = intel_dp->DP; > > > > - if (WARN_ON(HAS_DDI(dev_priv))) > > - return; > > - > > if (WARN_ON((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0)) > > return; > > > > -- > > 2.21.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
