Re: [PATCH] drm/i915: Move i915_check_and_clear_faults to intel_reset.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-06-07 12:59:32)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> The code is logically about reset so it makes sense.
> 
> It also enables making i915_clear_error_registers static.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Suggested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Yup, looks like a step in the right direction.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I can't decide just quite how it should look between the engines
sanitizing the stray errors, or if we should do an intel_reset_init /
intel_reset_sanitize pass.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux