== Series Details == Series: Display uncore URL : https://patchwork.freedesktop.org/series/61735/ State : warning == Summary == $ dim checkpatch origin/drm-tip ce3c9cc8889e drm/i915: use vfuncs for reg_read/write_fw_domains -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/intel_uncore.c:1155: +#define __gen_reg_read_funcs(func) \ +static enum forcewake_domains \ +func##_reg_read_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \ + return __##func##_reg_read_fw_domains(uncore, i915_mmio_reg_offset(reg)); \ +} \ +\ +__gen_read(func, 8) \ +__gen_read(func, 16) \ +__gen_read(func, 32) \ +__gen_read(func, 64) -:81: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #81: FILE: drivers/gpu/drm/i915/intel_uncore.c:1231: } +__gen6_write(8) -:112: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #112: FILE: drivers/gpu/drm/i915/intel_uncore.c:1247: +#define __gen_reg_write_funcs(func) \ +static enum forcewake_domains \ +func##_reg_write_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \ + return __##func##_reg_write_fw_domains(uncore, i915_mmio_reg_offset(reg)); \ +} \ +\ +__gen_write(func, 8) \ +__gen_write(func, 16) \ +__gen_write(func, 32) -:131: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #131: FILE: drivers/gpu/drm/i915/intel_uncore.c:1265: +#define ASSIGN_WRITE_MMIO_VFUNCS_NO_FW(uncore, x) \ do { \ (uncore)->funcs.mmio_writeb = x##_write8; \ (uncore)->funcs.mmio_writew = x##_write16; \ (uncore)->funcs.mmio_writel = x##_write32; \ } while (0) -:139: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #139: FILE: drivers/gpu/drm/i915/intel_uncore.c:1272: +#define ASSIGN_READ_MMIO_VFUNCS_NO_FW(uncore, x) \ do { \ (uncore)->funcs.mmio_readb = x##_read8; \ (uncore)->funcs.mmio_readw = x##_read16; \ -:147: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #147: FILE: drivers/gpu/drm/i915/intel_uncore.c:1280: +#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \ +do { \ + ASSIGN_WRITE_MMIO_VFUNCS_NO_FW((uncore), x); \ + (uncore)->funcs.write_fw_domains = x##_reg_write_fw_domains; \ +} while (0) -:153: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #153: FILE: drivers/gpu/drm/i915/intel_uncore.c:1286: +#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \ +do { \ + ASSIGN_READ_MMIO_VFUNCS_NO_FW(uncore, x); \ + (uncore)->funcs.read_fw_domains = x##_reg_read_fw_domains; \ +} while (0) total: 0 errors, 0 warnings, 7 checks, 258 lines checked b98535f0b0c8 drm/i915: kill uncore_sanitize e3497827e11a drm/i915: dynamically allocate forcewake domains -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #31: FILE: drivers/gpu/drm/i915/intel_uncore.c:1287: +static int fw_domain_init(struct intel_uncore *uncore, enum forcewake_domain_id domain_id, -:105: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #105: FILE: drivers/gpu/drm/i915/intel_uncore.c:1366: +#define __fw_domain_init(id, set, ack) \ + ret = fw_domain_init(uncore, id, set, ack); \ + if (ret) \ + goto out_clean; -:105: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #105: FILE: drivers/gpu/drm/i915/intel_uncore.c:1366: +#define __fw_domain_init(id, set, ack) \ + ret = fw_domain_init(uncore, id, set, ack); \ + if (ret) \ + goto out_clean; -:105: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #105: FILE: drivers/gpu/drm/i915/intel_uncore.c:1366: +#define __fw_domain_init(id, set, ack) \ + ret = fw_domain_init(uncore, id, set, ack); \ + if (ret) \ + goto out_clean; total: 1 errors, 2 warnings, 1 checks, 277 lines checked fd56799f4e3b drm/i915: explicitly prune forcewake domain da903ca61fad drm/i915: split out uncore_mmio_debug 25c3e5c16e11 drm/i915: drop forcewake_user_get/put 8a0edebef2c6 drm/i915: introduce display_uncore 33f4d6c7a398 drm/i915: move intel_hdmi to de_uncore -:813: WARNING:LINE_SPACING: Missing a blank line after declarations #813: FILE: drivers/gpu/drm/i915/intel_hdmi.c:3139: + u32 temp = intel_uncore_read(&dev_priv->de_uncore, PEG_BAND_GAP_DATA); + intel_uncore_write(&dev_priv->de_uncore, PEG_BAND_GAP_DATA, total: 0 errors, 1 warnings, 0 checks, 755 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
