On Thu, Jun 06, 2019 at 09:09:08AM -0700, Lucas De Marchi wrote: > On Thu, Jun 06, 2019 at 09:00:56AM -0700, Rodrigo Vivi wrote: > > On Wed, Jun 05, 2019 at 03:15:22PM -0700, Matt Roper wrote: > > > On Wed, Jun 05, 2019 at 02:51:08PM -0700, Manasi Navare wrote: > > > > On Wed, Jun 05, 2019 at 02:18:32PM -0700, Matt Roper wrote: > > > > > Unlike ICL, EHL's combo PHYs can support HBR3 data rates. Note that > > > > > this just extends the upper limit; we will continue to honor the max > > > > > data rate specified in the VBT in cases where it is lower than HBR3. > > > > > > > > > > Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx> > > > > > > > > Yes looks good to me. > > > > > > > > Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> > > > > > > > > Manasi > > > > > > Thanks for the quick review. CI looks happy too, so pushed to dinq. > > > > > > > > > Matt > > > > > > > > > > > > --- > > > > > drivers/gpu/drm/i915/intel_dp.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > > > > index 24b56b2a76c8..b099a9dc28fd 100644 > > > > > --- a/drivers/gpu/drm/i915/intel_dp.c > > > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > > > > @@ -332,6 +332,7 @@ static int icl_max_source_rate(struct intel_dp *intel_dp) > > > > > enum port port = dig_port->base.port; > > > > > > > > > > if (intel_port_is_combophy(dev_priv, port) && > > > > > + !IS_ELKHARTLAKE(dev_priv) && > > > > I wonder if we shouldn't use IS_ICELAKE instead of !IS_ELKHARTLAKE here... > > but it seems to late... > > if we apply the principle we have been adopting of always using the last > platform for the next one... I agree, this should be IS_ICELAKE(). Makes sense. I assumed this was something more tied to EHL's lack of TC ports rather than something that would necessarily be carried forward to future platforms, but as you point out I probably shouldn't make guesses about future platforms like that and should just follow our existing convention of inheriting all features. I'll send a follow-up patch to flip this to IS_ICELAKE in a little bit. Matt > > Lucas De Marchi > > > > > But something to remember to pay attention on any upcoming platform... > > > > > > > !intel_dp_is_edp(intel_dp)) > > > > > return 540000; > > > > > > > > > > -- > > > > > 2.14.5 > > > > > > > > > > _______________________________________________ > > > > > Intel-gfx mailing list > > > > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > > -- > > > Matt Roper > > > Graphics Software Engineer > > > IoTG Platform Enabling & Development > > > Intel Corporation > > > (916) 356-2795 > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
