Re: [igt-dev] [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/05/2019 10:46, Chris Wilson wrote:
We can use offsetof for the same effect, much tidier with no dummy
locals.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
---
  benchmarks/gem_wsim.c | 15 ++++++---------
  1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index db19925b1..a76fdbfe2 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1443,23 +1443,20 @@ set_ctx_sseu(struct ctx *ctx, uint64_t slice_mask)
static size_t sizeof_load_balance(int count)
  {
-	struct i915_context_engines_load_balance *ptr;
-
-	return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+	return offsetof(struct i915_context_engines_load_balance,
+			engines[count]);
  }
static size_t sizeof_param_engines(int count)
  {
-	struct i915_context_param_engines *ptr;
-
-	return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+	return offsetof(struct i915_context_param_engines,
+			engines[count]);
  }
static size_t sizeof_engines_bond(int count)
  {
-	struct i915_context_engines_bond *ptr;
-
-	return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+	return offsetof(struct i915_context_engines_bond,
+			engines[count]);
  }
#define alloca0(sz) ({ size_t sz__ = (sz); memset(alloca(sz__), 0, sz__); })


Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux