== Series Details == Series: split out intel_display_power URL : https://patchwork.freedesktop.org/series/61453/ State : warning == Summary == $ dim checkpatch origin/drm-tip 757791efed23 drm/i915: extract intel_display_power.h/c from intel_runtime_pm.h/c -:64: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #64: new file mode 100644 -:69: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/intel_display_power.c', please use '//' instead #69: FILE: drivers/gpu/drm/i915/intel_display_power.c:1: +/* SPDX-License-Identifier: MIT */ -:69: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #69: FILE: drivers/gpu/drm/i915/intel_display_power.c:1: +/* SPDX-License-Identifier: MIT */ -:332: CHECK:LINE_SPACING: Please don't use multiple blank lines #332: FILE: drivers/gpu/drm/i915/intel_display_power.c:264: + + -:406: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pg' should also have an identifier name #406: FILE: drivers/gpu/drm/i915/intel_display_power.c:338: + enum skl_power_gate uninitialized_var(pg); -:931: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #931: FILE: drivers/gpu/drm/i915/intel_display_power.c:863: +static bool i9xx_always_on_power_well_enabled(struct drm_i915_private *dev_priv, + struct i915_power_well *power_well) -:1198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects? #1198: FILE: drivers/gpu/drm/i915/intel_display_power.c:1130: +#define BITS_SET(val, bits) (((val) & (bits)) == (bits)) -:3517: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well_descs' - possible side-effects? #3517: FILE: drivers/gpu/drm/i915/intel_display_power.c:3449: +#define set_power_wells(power_domains, __power_well_descs) \ + __set_power_wells(power_domains, __power_well_descs, \ + ARRAY_SIZE(__power_well_descs)) -:3621: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #3621: FILE: drivers/gpu/drm/i915/intel_display_power.c:3553: + udelay(10); -:3678: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #3678: FILE: drivers/gpu/drm/i915/intel_display_power.c:3610: + udelay(10); -:3697: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #3697: FILE: drivers/gpu/drm/i915/intel_display_power.c:3629: + udelay(10); -:3987: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #3987: FILE: drivers/gpu/drm/i915/intel_display_power.c:3919: +static void skl_display_core_init(struct drm_i915_private *dev_priv, + bool resume) -:4528: WARNING:LINE_SPACING: Missing a blank line after declarations #4528: FILE: drivers/gpu/drm/i915/intel_display_power.c:4460: + struct i915_power_domains *power_domains = &i915->power_domains; + intel_wakeref_t wakeref __maybe_unused = -:4707: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name #4707: FILE: drivers/gpu/drm/i915/intel_display_power.h:21: +int intel_power_domains_init(struct drm_i915_private *); -:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84: +#define with_intel_display_power(i915, domain, wf) \ + for ((wf) = intel_display_power_get((i915), (domain)); (wf); \ + intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0) -:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects? #4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84: +#define with_intel_display_power(i915, domain, wf) \ + for ((wf) = intel_display_power_get((i915), (domain)); (wf); \ + intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0) -:4770: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #4770: FILE: drivers/gpu/drm/i915/intel_display_power.h:84: +#define with_intel_display_power(i915, domain, wf) \ + for ((wf) = intel_display_power_get((i915), (domain)); (wf); \ + intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0) total: 0 errors, 6 warnings, 11 checks, 9706 lines checked 392ffe04011b drm/i915: move more defs in intel_display_power.h -:304: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tran' - possible side-effects? #304: FILE: drivers/gpu/drm/i915/intel_display_power.h:70: +#define POWER_DOMAIN_TRANSCODER(tran) \ + ((tran) == TRANSCODER_EDP ? POWER_DOMAIN_TRANSCODER_EDP : \ + (tran) + POWER_DOMAIN_TRANSCODER_A) -:407: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #407: FILE: drivers/gpu/drm/i915/intel_display_power.h:173: + struct mutex lock; -:417: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects? #417: FILE: drivers/gpu/drm/i915/intel_display_power.h:183: +#define for_each_power_domain(domain, mask) \ + for ((domain) = 0; (domain) < POWER_DOMAIN_NUM; (domain)++) \ + for_each_if(BIT_ULL(domain) & (mask)) -:421: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #421: FILE: drivers/gpu/drm/i915/intel_display_power.h:187: +#define for_each_power_well(__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells; \ + (__power_well) - (__dev_priv)->power_domains.power_wells < \ + (__dev_priv)->power_domains.power_well_count; \ + (__power_well)++) -:421: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #421: FILE: drivers/gpu/drm/i915/intel_display_power.h:187: +#define for_each_power_well(__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells; \ + (__power_well) - (__dev_priv)->power_domains.power_wells < \ + (__dev_priv)->power_domains.power_well_count; \ + (__power_well)++) -:427: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #427: FILE: drivers/gpu/drm/i915/intel_display_power.h:193: +#define for_each_power_well_reverse(__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells + \ + (__dev_priv)->power_domains.power_well_count - 1; \ + (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \ + (__power_well)--) -:427: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #427: FILE: drivers/gpu/drm/i915/intel_display_power.h:193: +#define for_each_power_well_reverse(__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells + \ + (__dev_priv)->power_domains.power_well_count - 1; \ + (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \ + (__power_well)--) -:433: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #433: FILE: drivers/gpu/drm/i915/intel_display_power.h:199: +#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \ + for_each_power_well(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) -:433: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #433: FILE: drivers/gpu/drm/i915/intel_display_power.h:199: +#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \ + for_each_power_well(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) -:437: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #437: FILE: drivers/gpu/drm/i915/intel_display_power.h:203: +#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \ + for_each_power_well_reverse(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) -:437: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #437: FILE: drivers/gpu/drm/i915/intel_display_power.h:203: +#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \ + for_each_power_well_reverse(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) total: 2 errors, 0 warnings, 9 checks, 412 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
