== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/61238/ State : warning == Summary == $ dim checkpatch origin/drm-tip 754614561b92 drm/i915: Split GEM object type definition to its own header -:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 -:62: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #62: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:1: +/* -:63: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #63: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:2: + * SPDX-License-Identifier: MIT -:180: WARNING:LINE_SPACING: Missing a blank line after declarations #180: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:119: + struct list_head batch_pool_link; + I915_SELFTEST_DECLARE(struct list_head st_link); -:439: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #439: FILE: drivers/gpu/drm/i915/i915_gem_object.h:2: + * SPDX-License-Identifier: MIT total: 0 errors, 5 warnings, 0 checks, 664 lines checked 3bf61b613844 drm/i915: Pull GEM ioctls interface to its own file -:12: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 -:17: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #17: FILE: drivers/gpu/drm/i915/gem/i915_gem_ioctls.h:1: +/* -:18: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #18: FILE: drivers/gpu/drm/i915/gem/i915_gem_ioctls.h:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 152 lines checked 2883eec96483 drm/i915: Move object->pages API to i915_gem_object.[ch] -:38: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #38: rename from drivers/gpu/drm/i915/i915_gem_object.c total: 0 errors, 1 warnings, 0 checks, 338 lines checked 1d9a90a249df drm/i915: Move shmem object setup to its own file -:413: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #413: new file mode 100644 -:418: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #418: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:1: +/* -:419: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #419: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 2002 lines checked e90d900880b9 drm/i915: Move phys objects to its own file -:80: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 -:85: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #85: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:1: +/* -:86: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #86: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:2: + * SPDX-License-Identifier: MIT -:184: WARNING:MEMORY_BARRIER: memory barrier without comment #184: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:100: + smp_mb__before_atomic(); -:249: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #249: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:165: + obj->mm.page_sizes.phys = obj->mm.page_sizes.sg = 0; -:375: WARNING:MEMORY_BARRIER: memory barrier without comment #375: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:291: + smp_mb__before_atomic(); -:394: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #394: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:310: + ptr = obj->mm.mapping = NULL; -:612: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #612: FILE: drivers/gpu/drm/i915/gem/i915_gem_phys.c:1: +/* -:613: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #613: FILE: drivers/gpu/drm/i915/gem/i915_gem_phys.c:2: + * SPDX-License-Identifier: MIT -:908: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #908: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_phys.c:1: +/* -:909: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #909: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_phys.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 9 warnings, 2 checks, 1848 lines checked b11107db2022 drm/i915: Move mmap and friends to its own file -:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 -:30: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #30: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:1: +/* -:31: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #31: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:2: + * SPDX-License-Identifier: MIT -:592: WARNING:MEMORY_BARRIER: memory barrier without comment #592: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:399: + wmb(); -:635: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #635: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:1: +/* -:636: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #636: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:2: + * SPDX-License-Identifier: MIT -:829: WARNING:LONG_LINE: line over 100 characters #829: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:195: + (1 + next_prime_number(i915->ggtt.vm.total >> PAGE_SHIFT)) << PAGE_SHIFT); -:948: WARNING:SPACING: space prohibited before semicolon #948: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:314: +next_tiling: ; total: 0 errors, 8 warnings, 0 checks, 2261 lines checked 88524c7e5e4b drm/i915: Move GEM domain management to its own file -:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 -:30: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #30: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:1: +/* -:31: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #31: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:2: + * SPDX-License-Identifier: MIT -:111: WARNING:MEMORY_BARRIER: memory barrier without comment #111: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:82: + mb(); -:173: WARNING:MEMORY_BARRIER: memory barrier without comment #173: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:144: + mb(); total: 0 errors, 5 warnings, 0 checks, 1869 lines checked af488c202969 drm/i915: Move more GEM objects under gem/ -:88: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #88: rename from drivers/gpu/drm/i915/i915_gem_clflush.c -:115: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #115: FILE: drivers/gpu/drm/i915/gem/i915_gem_clflush.c:2: + * SPDX-License-Identifier: MIT -:133: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #133: FILE: drivers/gpu/drm/i915/gem/i915_gem_clflush.h:1: +/* -:134: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #134: FILE: drivers/gpu/drm/i915/gem/i915_gem_clflush.h:2: + * SPDX-License-Identifier: MIT -:185: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #185: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:2: + * SPDX-License-Identifier: MIT -:229: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #229: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.h:2: + * SPDX-License-Identifier: MIT -:260: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #260: FILE: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:2: + * SPDX-License-Identifier: MIT -:318: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #318: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2: + * SPDX-License-Identifier: MIT -:367: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #367: FILE: drivers/gpu/drm/i915/gem/i915_gem_internal.c:2: + * SPDX-License-Identifier: MIT -:463: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #463: FILE: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:2: + * SPDX-License-Identifier: MIT -:510: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #510: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:2: + * SPDX-License-Identifier: MIT -:556: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #556: FILE: drivers/gpu/drm/i915/gem/i915_gem_tiling.c:2: + * SPDX-License-Identifier: MIT -:603: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #603: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2: + * SPDX-License-Identifier: MIT -:650: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #650: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:2: + * SPDX-License-Identifier: MIT -:662: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #662: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.h:1: +/* -:663: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #663: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.h:2: + * SPDX-License-Identifier: MIT -:707: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #707: FILE: drivers/gpu/drm/i915/gem/selftests/huge_gem_object.c:2: + * SPDX-License-Identifier: MIT -:719: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #719: FILE: drivers/gpu/drm/i915/gem/selftests/huge_gem_object.h:1: +/* -:720: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #720: FILE: drivers/gpu/drm/i915/gem/selftests/huge_gem_object.h:2: + * SPDX-License-Identifier: MIT -:775: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #775: FILE: drivers/gpu/drm/i915/gem/selftests/huge_pages.c:2: + * SPDX-License-Identifier: MIT -:828: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #828: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c:2: + * SPDX-License-Identifier: MIT -:871: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #871: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:2: + * SPDX-License-Identifier: MIT -:933: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #933: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c:2: + * SPDX-License-Identifier: MIT -:990: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #990: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c:2: + * SPDX-License-Identifier: MIT -:1061: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #1061: FILE: drivers/gpu/drm/i915/gem/selftests/mock_context.c:2: + * SPDX-License-Identifier: MIT -:1078: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1078: FILE: drivers/gpu/drm/i915/gem/selftests/mock_context.h:1: +/* -:1079: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #1079: FILE: drivers/gpu/drm/i915/gem/selftests/mock_context.h:2: + * SPDX-License-Identifier: MIT -:1131: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #1131: FILE: drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.c:2: + * SPDX-License-Identifier: MIT -:1143: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1143: FILE: drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.h:1: +/* -:1144: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #1144: FILE: drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.h:2: + * SPDX-License-Identifier: MIT -:1174: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1174: FILE: drivers/gpu/drm/i915/gem/selftests/mock_gem_object.h:1: +/* -:1175: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #1175: FILE: drivers/gpu/drm/i915/gem/selftests/mock_gem_object.h:2: + * SPDX-License-Identifier: MIT total: 0 errors, 32 warnings, 0 checks, 1394 lines checked 2d3eb9dbf3e3 drm/i915: Pull scatterlist utils out of i915_gem.h -:371: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #371: new file mode 100644 -:376: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #376: FILE: drivers/gpu/drm/i915/i915_scatterlist.c:1: +/* -:377: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #377: FILE: drivers/gpu/drm/i915/i915_scatterlist.c:2: + * SPDX-License-Identifier: MIT -:421: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #421: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:1: +/* -:422: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #422: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:2: + * SPDX-License-Identifier: MIT -:451: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #451: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:31: + s.max = s.curr = s.sgp->offset; -:496: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__iter' - possible side-effects? #496: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:76: +#define __for_each_sgt_dma(__dmap, __iter, __sgt, __step) \ + for ((__iter) = __sgt_iter((__sgt)->sgl, true); \ + ((__dmap) = (__iter).dma + (__iter).curr); \ + (((__iter).curr += (__step)) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0 : 0) -:508: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__iter' - possible side-effects? #508: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:88: +#define for_each_sgt_page(__pp, __iter, __sgt) \ + for ((__iter) = __sgt_iter((__sgt)->sgl, false); \ + ((__pp) = (__iter).pfn == 0 ? NULL : \ + pfn_to_page((__iter).pfn + ((__iter).curr >> PAGE_SHIFT))); \ + (((__iter).curr += PAGE_SIZE) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), false), 0 : 0) total: 0 errors, 5 warnings, 3 checks, 458 lines checked d154799bd258 drm/i915: Move GEM object domain management from struct_mutex to local -:525: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #525: new file mode 100644 -:530: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #530: FILE: drivers/gpu/drm/i915/gem/i915_gem_fence.c:1: +/* -:531: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #531: FILE: drivers/gpu/drm/i915/gem/i915_gem_fence.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 1446 lines checked 31970d678eae drm/i915: Move GEM object waiting to its own file -:42: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 -:47: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #47: FILE: drivers/gpu/drm/i915/gem/i915_gem_wait.c:1: +/* -:48: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #48: FILE: drivers/gpu/drm/i915/gem/i915_gem_wait.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 591 lines checked f5041c664af8 drm/i915: Move GEM object busy checking to its own file -:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 -:30: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #30: FILE: drivers/gpu/drm/i915/gem/i915_gem_busy.c:1: +/* -:31: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #31: FILE: drivers/gpu/drm/i915/gem/i915_gem_busy.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 279 lines checked f6e7c1639263 drm/i915: Move GEM client throttling to its own file -:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 -:30: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #30: FILE: drivers/gpu/drm/i915/gem/i915_gem_throttle.c:1: +/* -:31: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #31: FILE: drivers/gpu/drm/i915/gem/i915_gem_throttle.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 3 warnings, 0 checks, 162 lines checked 835f1367b9dd drm/i915: Rename intel_context.active to .inflight f88b4b6b6b89 drm/i915: Drop the deferred active reference _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
