== Series Details == Series: Refactor to expand subslice mask (rev10) URL : https://patchwork.freedesktop.org/series/59742/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d605edfee68 drm/i915: Use local variable for SSEU info in GETPARAM ioctl 1b9931fa807c drm/i915: Add macro for SSEU stride calculation 3ff1c4ffe466 drm/i915: Move calculation of subslices per slice to new function 9380b92a1933 drm/i915: Refactor sseu helper functions 1b9826e9f3ff drm/i915: Expand subslice mask -:115: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible side-effects? #115: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:558: +#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \ + (IS_GEN(dev_priv__, 7) ? (1 & BIT(subslice__)) : \ + intel_sseu_has_subslice(sseu__, slice__, subslice__)) -:119: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv_' - possible side-effects? #119: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:562: +#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \ + for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \ + (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \ + (slice_) += ((subslice_) == 0)) \ + for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \ + (instdone_has_subslice(dev_priv_, sseu_, slice_, \ + subslice_))) -:119: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sseu_' - possible side-effects? #119: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:562: +#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \ + for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \ + (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \ + (slice_) += ((subslice_) == 0)) \ + for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \ + (instdone_has_subslice(dev_priv_, sseu_, slice_, \ + subslice_))) -:119: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice_' - possible side-effects? #119: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:562: +#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \ + for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \ + (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \ + (slice_) += ((subslice_) == 0)) \ + for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \ + (instdone_has_subslice(dev_priv_, sseu_, slice_, \ + subslice_))) -:119: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice_' - possible side-effects? #119: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:562: +#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \ + for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \ + (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \ + (slice_) += ((subslice_) == 0)) \ + for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \ + (instdone_has_subslice(dev_priv_, sseu_, slice_, \ + subslice_))) total: 0 errors, 0 warnings, 5 checks, 679 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
