== Series Details == Series: fbcon notifier begone! (rev3) URL : https://patchwork.freedesktop.org/series/60843/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9f0a699de21c dummycon: Sprinkle locking checks -:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 23 lines checked f22835ba447d fbdev: locking check for fb_set_suspend -:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked 8a48cbffe81f vt: might_sleep() annotation for do_blank_screen -:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked cbd84611f343 vt: More locking checks -:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 38 lines checked 2b513d008252 fbdev/sa1100fb: Remove dead code -:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 35 lines checked a3b67c702b95 fbdev/cyber2000: Remove struct display -:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 7 lines checked 995b6d6edd33 fbdev/aty128fb: Remove dead code -:88: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 70 lines checked d93edf952696 fbcon: s/struct display/struct fbcon_display/ -:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #270: FILE: drivers/video/fbdev/core/fbcon.c:2117: +static void updatescrollmode(struct fbcon_display *p, struct fb_info *info, -:384: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 1 checks, 317 lines checked f74ffc508b81 fbcon: Remove fbcon_has_exited -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")' #11: commit 6104c37094e729f3d4ce65797002112735d49cd1 -:83: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #83: FILE: drivers/video/fbdev/core/fbcon.c:1065: + if (WARN_ON(info_idx == -1)) return; -:193: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 2 warnings, 0 checks, 119 lines checked 65e571416e0a fbcon: call fbcon_fb_(un)registered directly -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")' #11: commit 6104c37094e729f3d4ce65797002112735d49cd1 -:155: WARNING:LINE_SPACING: Missing a blank line after declarations #155: FILE: drivers/video/fbdev/core/fbmem.c:1728: + struct fb_event event; + event.info = fb_info; -:190: WARNING:LINE_SPACING: Missing a blank line after declarations #190: FILE: drivers/video/fbdev/core/fbmem.c:1799: + struct fb_event event; + event.info = fb_info; -:237: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 3 warnings, 0 checks, 147 lines checked 554aa48edb9f fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify 742b35bae46d fbdev/omap: sysfs files can't disappear before the device is gone b80c8e5422b0 fbdev: sysfs files can't disappear before the device is gone 5e8820c9a8f6 staging/olpc: lock_fb_info can't fail 9d0c020031cf fbdev/atyfb: lock_fb_info can't fail 7b36ca43f945 fbdev: lock_fb_info cannot fail -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c47747fde931 ("fbmem: make read/write/ioctl use the frame buffer at open time")' #11: commit c47747fde931c02455683bd00ea43eaa62f35b0e -:307: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 212 lines checked 6206f93346b9 fbcon: call fbcon_fb_bind directly -:160: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 107 lines checked c00611f73ad1 fbdev: make unregister/unlink functions not fail -:284: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #284: FILE: include/linux/fb.h:637: +extern void unregister_framebuffer(struct fb_info *fb_info); -:285: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #285: FILE: include/linux/fb.h:638: +extern void unlink_framebuffer(struct fb_info *fb_info); -:288: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 2 checks, 226 lines checked 63e5a6ca8ea7 fbdev: unify unlink_framebuffer paths -:95: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 63 lines checked e81fd595bc00 fbdev/sh_mob: Remove fb notifier callback -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6011bdeaa608 ("fbdev: sh-mobile: HDMI support for SH-Mobile SoCs")' #21: commit 6011bdeaa6089d49c02de69f05980da7bad314ab -:107: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 62 lines checked dccfc685e1dc fbdev: directly call fbcon_suspended/resumed -:128: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 77 lines checked ec8cda3f49fb fbcon: Call fbcon_mode_deleted/new_modelist directly -:182: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 123 lines checked 469f9d259776 fbdev: Call fbcon_get_requirement directly -:118: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 68 lines checked e7c5a8669273 Revert "backlight/fbcon: Add FB_EVENT_CONBLANK" -:136: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 80 lines checked 0e234a059fe0 fbmem: pull fbcon_fb_blanked out of fb_blank -:84: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead #84: FILE: drivers/video/fbdev/core/fbsysfs.c:311: + arg = simple_strtoul(buf, &last, 0); -:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 40 lines checked c740c3c17833 fbdev: remove FBINFO_MISC_USEREVENT around fb_blank -:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 30 lines checked 5d9e17ceb619 fb: Flatten control flow in fb_set_var -:141: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... #141: FILE: drivers/video/fbdev/core/fbmem.c:1027: + printk(KERN_WARNING "detected " -:188: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 156 lines checked 94a654b31b8a fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: to Maarten for spotting this. So we keep that. We can ditch the differentiation -:57: CHECK:LINE_SPACING: Please don't use multiple blank lines #57: FILE: drivers/video/fbdev/core/fbcon.c:3012: + -:184: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 1 checks, 114 lines checked ab33022e9599 vgaswitcheroo: call fbcon_remap_all directly -:132: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 83 lines checked d1f28ba00574 fbcon: Call con2fb_map functions directly -:87: WARNING:BRACES: braces {} are not necessary for single statement blocks #87: FILE: drivers/video/fbdev/core/fbcon.c:3335: + if (!registered_fb[con2fb.framebuffer]) { + return -EINVAL; } -:237: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 171 lines checked a3dba88493a1 fbcon: Document what I learned about fbcon locking -:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 25 lines checked 75caa7472f10 staging/olpc_dcon: Add drm conversion to TODO -:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 11 lines checked 23cf8c0c6470 backlight: simplify lcd notifier -:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 17 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
