Re: [PATCH 2/2] drm/i915: add syncobj timeline support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/05/2019 12:52, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-05-23 12:46:20)
-               syncobj = drm_syncobj_find(file, fence.handle);
-               if (!syncobj) {
-                       DRM_DEBUG("Invalid syncobj handle provided\n");
-                       err = -ENOENT;
-                       goto err;
+                       if (user_fence.flags & __I915_EXEC_FENCE_UNKNOWN_FLAGS) {
+                               err = -EINVAL;
+                               goto err;
+                       }
+
+                       if (user_fence.flags & I915_EXEC_FENCE_WAIT) {
+                               err = drm_syncobj_find_fence(
+                                       file, user_fence.handle, user_fence.value,
+                                       DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT,
+                                       &syncobj, &fence);
Is this still a synchronous wait? That would be an unfortunate change in
behaviour and antithesis to having a scheduler.
-Chris

Not sure what you mean by synchronous wait.

We have to be able to call the submit before all the fences we depend on have materialized.


-Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux