Re: [igt-dev] [PATCH i-g-t] lib/i915: Fix pointer cast build issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-05-22 16:04:13)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> Use from_user_pointer when casting __u64 to a pointer.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Andi Shyti <andi.shyti@xxxxxxxxx>
> ---
>  lib/i915/gem_engine_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> index dd26fae00853..7ca3616687b9 100644
> --- a/lib/i915/gem_engine_topology.c
> +++ b/lib/i915/gem_engine_topology.c
> @@ -81,7 +81,7 @@ static void ctx_map_engines(int fd, struct intel_engine_data *ed,
>                             struct drm_i915_gem_context_param *param)
>  {
>         struct i915_context_param_engines *engines =
> -                       (struct i915_context_param_engines *) param->value;
> +                       from_user_pointer(param->value);

Only a single tab indent required.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

>         int i = 0;
>  
>         for (typeof(engines->engines[0]) *p =

And struct i915_engine_class_instance was added to make this for() loop
nicer.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux