✗ Fi.CI.CHECKPATCH: warning for fbcon notifier begone!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: fbcon notifier begone!
URL   : https://patchwork.freedesktop.org/series/60843/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
055b00c0fe75 dummycon: Sprinkle locking checks
-:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 23 lines checked
4e37022aa93c fbdev: locking check for fb_set_suspend
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
9a1b9bd2fe54 vt: might_sleep() annotation for do_blank_screen
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
0b0436a4cf45 vt: More locking checks
-:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 38 lines checked
c4874367788b fbdev/sa1100fb: Remove dead code
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 35 lines checked
05d067aaf0c6 fbdev/cyber2000: Remove struct display
-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
952fc4d78a9a fbdev/aty128fb: Remove dead code
-:88: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 70 lines checked
a43b8f82dead fbcon: s/struct display/struct fbcon_display/
-:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#270: FILE: drivers/video/fbdev/core/fbcon.c:2117:
+static void updatescrollmode(struct fbcon_display *p,
 					struct fb_info *info,

-:384: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 1 checks, 317 lines checked
d4f5dc8d37ec fbcon: Remove fbcon_has_exited
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11: 
commit 6104c37094e729f3d4ce65797002112735d49cd1

-:162: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 105 lines checked
35546ee18ade fbcon: call fbcon_fb_(un)registered directly
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11: 
commit 6104c37094e729f3d4ce65797002112735d49cd1

-:168: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 108 lines checked
fecd97482aa7 fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
fc2648b2ee9c fbdev/omap: sysfs files can't disappear before the device is gone
c8c698e0756d fbdev: sysfs files can't disappear before the device is gone
235cf63d6d1d staging/olpc: lock_fb_info can't fail
d7b435d6fd4e fbdev/atyfb: lock_fb_info can't fail
5b5267d29e9b fbdev: lock_fb_info cannot fail
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c47747fde931 ("fbmem: make read/write/ioctl use the frame buffer at open time")'
#11: 
commit c47747fde931c02455683bd00ea43eaa62f35b0e

-:307: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 212 lines checked
f3e57d9fc39b fbcon: call fbcon_fb_bind directly
-:160: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 107 lines checked
1d4a7a51b9bd fbdev: make unregister/unlink functions not fail
-:209: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#209: FILE: include/linux/fb.h:630:
+extern void unregister_framebuffer(struct fb_info *fb_info);

-:210: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#210: FILE: include/linux/fb.h:631:
+extern void unlink_framebuffer(struct fb_info *fb_info);

-:213: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 2 checks, 174 lines checked
bc6430295335 fbdev: unify unlink_framebufer paths
-:92: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 63 lines checked
c7f216feeeb6 fbdev/sh_mob: Remove fb notifier callback
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6011bdeaa608 ("fbdev: sh-mobile: HDMI support for SH-Mobile SoCs")'
#21: 
commit 6011bdeaa6089d49c02de69f05980da7bad314ab

-:105: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 62 lines checked
dd9bf1dec0f3 fbdev: directly call fbcon_suspended/resumed
-:126: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 77 lines checked
584850e84e28 fbcon: Call fbcon_mode_deleted/new_modelist directly
-:175: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#175: FILE: include/linux/fbcon.h:23:
+int fbcon_mode_deleted(struct fb_info *info,
+		       struct fb_videomode *mode) { return 0; }

-:180: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 123 lines checked
b77db88cab5e fbdev: Call fbcon_get_requirement directly
-:112: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#112: FILE: include/linux/fbcon.h:28:
+void fbcon_get_requirement(struct fb_info *info,
+			   struct fb_blit_caps *caps) {}

-:116: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 1 errors, 1 warnings, 0 checks, 68 lines checked
04d78e43249a Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"
-:83: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 42 lines checked
f68577706206 fbcon: directly call fbcon_fb_blanked
-:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 38 lines checked
416fd80b5fa6 fbmem: pull fbcon_fb_blanked out of fb_blank
-:84: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead
#84: FILE: drivers/video/fbdev/core/fbsysfs.c:311:
+	arg = simple_strtoul(buf, &last, 0);

-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 2 warnings, 0 checks, 40 lines checked
f3db74aa6af7 fbdev: remove FBINFO_MISC_USEREVENT around fb_blank
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 30 lines checked
fe0d240ac210 fb: Flatten control flow in fb_set_var
-:141: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
#141: FILE: drivers/video/fbdev/core/fbmem.c:1027:
+			printk(KERN_WARNING "detected "

-:188: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 2 warnings, 0 checks, 156 lines checked
982d2147a85c fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls
-:46: CHECK:LINE_SPACING: Please don't use multiple blank lines
#46: FILE: drivers/video/fbdev/core/fbcon.c:3008:
 
+

-:164: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 1 checks, 107 lines checked
03c8d586c1a7 vgaswitcheroo: call fbcon_remap_all directly
-:126: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 82 lines checked
771b9daec03d fbcon: Call con2fb_map functions directly
-:73: WARNING:BRACES: braces {} are not necessary for single statement blocks
#73: FILE: drivers/video/fbdev/core/fbcon.c:3331:
+	if (!registered_fb[con2fb.framebuffer]) {
+		return -EINVAL;
 	}

-:208: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 2 warnings, 0 checks, 156 lines checked
4f6362b7429b fbcon: Document what I learned about fbcon locking
-:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 25 lines checked
67c24914765c staging/olpc_dcon: Add drm conversion to TODO
-:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>'

total: 0 errors, 1 warnings, 0 checks, 11 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux