== Series Details == Series: Runtime PM encapsulation URL : https://patchwork.freedesktop.org/series/60751/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6abe6de9d69c drm/i915: prefer i915_runtime_pm in intel_runtime function 459ce16ea796 drm/i915: Remove rpm asserts that use i915 3786ba59fb44 drm/i915: make enable/disable rpm assert function use the rpm structure f9fd0f317814 drm/i915: move and rename i915_runtime_pm -:527: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #527: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:62: + spinlock_t lock; total: 0 errors, 0 warnings, 1 checks, 585 lines checked 5fade456b0bf drm/i915: move a few more functions to accept the rpm structure 14c3a5f20ed6 drm/i915: update rpm_get/put to use the rpm structure 2701026b6f98 drm/i915: update with_intel_runtime_pm to use the rpm structure -:399: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rpm' - possible side-effects? #399: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:253: +#define with_intel_runtime_pm(rpm, wf) \ + for ((wf) = intel_runtime_pm_get(rpm); (wf); \ + intel_runtime_pm_put((rpm), (wf)), (wf) = 0) -:399: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #399: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:253: +#define with_intel_runtime_pm(rpm, wf) \ + for ((wf) = intel_runtime_pm_get(rpm); (wf); \ + intel_runtime_pm_put((rpm), (wf)), (wf) = 0) -:406: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rpm' - possible side-effects? #406: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:257: +#define with_intel_runtime_pm_if_in_use(rpm, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(rpm); (wf); \ + intel_runtime_pm_put((rpm), (wf)), (wf) = 0) -:406: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #406: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:257: +#define with_intel_runtime_pm_if_in_use(rpm, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(rpm); (wf); \ + intel_runtime_pm_put((rpm), (wf)), (wf) = 0) total: 0 errors, 0 warnings, 4 checks, 396 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx