Re: [PATCH] drm/i915: Reboot CI if forcewake fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Mika Kuoppala (2019-05-08 13:18:06)
> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
> 
> > If the HW fail to ack a change in forcewake status, the machine is as
> > good as dead -- it may recover, but in reality it missed the mmio
> > updates and is now in a very inconsistent state. If it happens, we can't
> > trust the CI results (or at least the fails may be genuine but due to
> > the HW being dead and not the actual test!) so reboot the machine (CI
> > checks for a kernel taint in between each test and reboots if the
> > machine is tainted).
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> 
> Sounds and looks reasonable. Should we also taint if we have
> unclaimed mmio after init sequence?

The unclaimed mmio throws a WARN so it naturally gets the
add_taint(TAINT_WARN) and CI reboots already. Otherwise, yes :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux