== Series Details == Series: drm/i915: the great header refactoring, part two (rev3) URL : https://patchwork.freedesktop.org/series/60060/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2505cc046d89 drm/i915: ensure more headers remain self-contained 2519e59bfa55 drm/i915: make intel_bios.h self-contained 339e512f1859 drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained -:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #129: rename from drivers/gpu/drm/i915/dvo.h total: 0 errors, 1 warnings, 0 checks, 98 lines checked 2292546de356 drm/i915: make intel_dpll_mgr.h self-contained 4e0a21377271 drm/i915: move dsi init functions to intel_dsi.h 2dcc56d461d3 drm/i915: extract intel_fifo_underrun.h from intel_drv.h -:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #129: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 116 lines checked 5fd2a3caa0c7 drm/i915: extract intel_dp_link_training.h from intel_drv.h -:69: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 52 lines checked 51eed658a60c drm/i915: extract intel_dp_aux_backlight.h from intel_drv.h -:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 43 lines checked 4433af4d6057 drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h -:168: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #168: new file mode 100644 -:188: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #188: FILE: drivers/gpu/drm/i915/i915_irq.h:16: +extern void intel_irq_init(struct drm_i915_private *dev_priv); -:189: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #189: FILE: drivers/gpu/drm/i915/i915_irq.h:17: +extern void intel_irq_fini(struct drm_i915_private *dev_priv); -:217: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #217: FILE: drivers/gpu/drm/i915/i915_irq.h:45: +} +static inline void -:222: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #222: FILE: drivers/gpu/drm/i915/i915_irq.h:50: +} +void bdw_update_pipe_irq(struct drm_i915_private *dev_priv, -:231: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #231: FILE: drivers/gpu/drm/i915/i915_irq.h:59: +} +static inline void bdw_disable_pipe_irq(struct drm_i915_private *dev_priv, -:236: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #236: FILE: drivers/gpu/drm/i915/i915_irq.h:64: +} +void ibx_display_interrupt_update(struct drm_i915_private *dev_priv, -:244: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #244: FILE: drivers/gpu/drm/i915/i915_irq.h:72: +} +static inline void total: 0 errors, 1 warnings, 7 checks, 293 lines checked ec6036c7c4df drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h -:170: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #170: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 142 lines checked 41a1ebe270b9 drm/i915: extract intel_bios.h functions from i915_drv.h 466f619fd083 drm/i915: extract intel_quirks.h from intel_drv.h -:74: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 46 lines checked d48f8b2660a6 drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h -:144: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #144: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 111 lines checked 36c6b9b871fa drm/i915: extract intel_vdsc.h from intel_drv.h and i915_drv.h -:116: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #116: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 80 lines checked be18937f7a04 drm/i915: extract intel_dp_mst.h from intel_drv.h -:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 45 lines checked 49f7818ffe49 drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h -:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 52 lines checked 1c720f4bb707 drm/i915: extract intel_atomic.h from intel_drv.h -:80: WARNING:LINE_SPACING: Missing a blank line after declarations #80: FILE: drivers/gpu/drm/i915/intel_atomic.c:421: + struct drm_crtc_state *crtc_state; + crtc_state = drm_atomic_get_crtc_state(state, &crtc->base); -:87: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #87: new file mode 100644 -:128: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #128: FILE: drivers/gpu/drm/i915/intel_atomic.h:37: +void intel_crtc_destroy_state(struct drm_crtc *crtc, + struct drm_crtc_state *state); total: 0 errors, 2 warnings, 1 checks, 195 lines checked c51954e0fb9f drm/i915: extract intel_runtime_pm.h from intel_drv.h -:153: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #153: new file mode 100644 -:171: WARNING:NEW_TYPEDEFS: do not add new typedefs #171: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:14: +typedef depot_stack_handle_t intel_wakeref_t; -:186: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_private *' should also have an identifier name #186: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:29: +int intel_power_domains_init(struct drm_i915_private *); -:232: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #232: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:75: +#define with_intel_runtime_pm(i915, wf) \ + for ((wf) = intel_runtime_pm_get(i915); (wf); \ + intel_runtime_pm_put((i915), (wf)), (wf) = 0) -:232: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #232: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:75: +#define with_intel_runtime_pm(i915, wf) \ + for ((wf) = intel_runtime_pm_get(i915); (wf); \ + intel_runtime_pm_put((i915), (wf)), (wf) = 0) -:236: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #236: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:79: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(i915); (wf); \ + intel_runtime_pm_put((i915), (wf)), (wf) = 0) -:236: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #236: FILE: drivers/gpu/drm/i915/intel_runtime_pm.h:79: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for ((wf) = intel_runtime_pm_get_if_in_use(i915); (wf); \ + intel_runtime_pm_put((i915), (wf)), (wf) = 0) total: 0 errors, 3 warnings, 4 checks, 224 lines checked 99417c6d3e94 drm/i915: move some leftovers to intel_pm.h from i915_drv.h -:107: CHECK:LINE_SPACING: Please don't use multiple blank lines #107: FILE: drivers/gpu/drm/i915/intel_pm.h:80: + + total: 0 errors, 0 warnings, 1 checks, 72 lines checked 4c4daecb680c drm/i915: extract intel_combo_phy.h from i915_drv.h -:62: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 49 lines checked 9b2338881b2b drm/i915: add single combo phy init/unit functions _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
